Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 467138 - media-gfx/mcomix should not RDEPEND on app-arch/unrar
Summary: media-gfx/mcomix should not RDEPEND on app-arch/unrar
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ryan Hill (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 01:22 UTC by Mateusz Kowalczyk
Modified: 2013-05-26 07:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff between the desired and current ebuild mcomix-0.99-r1.ebuild (ebuild_diff,88 bytes, patch)
2013-04-25 01:22 UTC, Mateusz Kowalczyk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Kowalczyk 2013-04-25 01:22:46 UTC
Created attachment 346556 [details, diff]
diff between the desired and current ebuild mcomix-0.99-r1.ebuild

mcomix installs and runs just fine without unrar: a run time exception is thrown that and handled by the program when unrar is not present. 

The user is shown a message explaining that the format is not supported. This option is fairly important as a GPL v2 program pulls in a unRAR (proprietary, non-free) licensed one when it's not absolutely necessary.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-04-25 12:30:44 UTC
Comment on attachment 346556 [details, diff]
diff between the desired and current ebuild mcomix-0.99-r1.ebuild

Adding optional runtime dependencies through USE flags without altering what the ebuild installs is regarded as a QA problem. If rar support is optional, and the software already explains that as needed, then changing a USE flag for the sake of installing an extra package doesn't really accomplish anything.
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2013-04-26 03:45:16 UTC
The vast majority of comics available are in cbr format, hence the dep.  There were also broken versions in the tree which required a blocker, but that's no longer true.  I'll think about it.
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2013-05-26 07:19:17 UTC
Fixed in 1.00.