Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 467036 - sci-chemistry/imosflm-1.0.7 ships broken embedded png
Summary: sci-chemistry/imosflm-1.0.7 ships broken embedded png
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 468386
  Show dependency tree
 
Reported: 2013-04-24 05:02 UTC by Johan Hattne
Modified: 2014-04-08 13:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed embedded png image (1.0.7-contrast.patch,1.24 KB, patch)
2013-04-24 05:03 UTC, Johan Hattne
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Hattne 2013-04-24 05:02:23 UTC
The png image embedded in src/contrast.tcl appears to suffer from "minor zlib-header breakage caused by libpng 1.2.6".  Extracting the png and running it through png-fix-IDAT-windowsize from media-gfx/pngcheck fixes the problem.

Reproducible: Always

Steps to Reproduce:
1. imosflm

Actual Results:  
MOSFLM_EXEC set to /net/marbles/raid1/hattne/gentoo/usr/libexec/ccp4/bin/ipmosflm
testing MOSFLM_WISH (/net/marbles/raid1/hattne/gentoo/usr/bin/wish)
Tcl platform is unix x86_64 Linux  2.6.32-220.el6.x86_64
TclTk version from info patchlevel is 8.6.0
Error in startup script: IDAT: invalid distance too far back
    while executing
"image create photo ::img::pixel_count_v -data "iVBORw0KGgoAAAANSUhEUgAAAA4AAABCCAIAAAGft0AHAAAABGdBTUEAAYagMeiWXwAAASFJREFUKJGtVFEWhCAINJ9H4f4n4jD7Yau..."
    (file "/net/marbles/raid1/hattne/gentoo/usr/lib/imosflm/src/contrast.tcl" line 6)
    invoked from within
"source /net/marbles/raid1/hattne/gentoo/usr/lib/imosflm/src/contrast.tcl"
    ("package ifneeded contrast 1.0" script)
    invoked from within
"package require contrast"
    (file "/net/marbles/raid1/hattne/gentoo/usr/lib/imosflm/src/imosflm.tcl" line 287)

Expected Results:  
MOSFLM_EXEC set to /net/marbles/raid1/hattne/gentoo/usr/libexec/ccp4/bin/ipmosflm
testing MOSFLM_WISH (/net/marbles/raid1/hattne/gentoo/usr/bin/wish)
Tcl platform is unix x86_64 Linux  2.6.32-220.el6.x86_64
TclTk version from info patchlevel is 8.6.0

!!! Your current profile is deprecated and not supported anymore.
!!! Use eselect profile to update your profile.
!!! Please upgrade to the following profile if possible:

        default/linux/amd64/13.0/no-multilib

You may use the following command to upgrade:

        eselect profile set default/linux/amd64/13.0/no-multilib

Portage 2.2.01.21890-prefix (prefix/linux/amd64, gcc-4.7.2, unavailable, 2.6.23.15-137.fc8 x86_64)
=================================================================
System uname: Linux-2.6.23.15-137.fc8-x86_64-Intel-R-_Xeon-R-_CPU_X7350_@_2.93GHz-with-fedora-8-Werewolf
KiB Mem:    33022968 total,  11459412 free
KiB Swap:   32767992 total,  30465448 free
Timestamp of tree: Tue, 23 Apr 2013 18:05:54 +0000
ld GNU ld (GNU Binutils) 2.23
ccache version 2.4 [disabled]
app-shells/bash:          4.2_p39-r1
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r3, 3.3.0-r1
dev-util/cmake:           2.8.10.2-r2
dev-util/pkgconfig:       0.28
sys-devel/autoconf:       2.69
sys-devel/automake:       1.12.4
sys-devel/binutils:       2.23
sys-devel/gcc:            4.7.2-r1
sys-devel/gcc-config:     1.8-r00.1
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8
Repositories: gentoo_prefix xtal-prefix
ACCEPT_KEYWORDS="~amd64-linux"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/net/marbles/raid1/hattne/gentoo/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles force-prefix merge-sync news parallel-fetch preserve-libs protect-owned sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j16"
PKGDIR="/net/marbles/raid1/hattne/gentoo/usr/portage/packages"
PORTAGE_CONFIGROOT="/net/marbles/raid1/hattne/gentoo/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp/hattne"
PORTDIR="/net/marbles/raid1/hattne/gentoo/usr/portage"
PORTDIR_OVERLAY="/net/cci/hattne/gentoo/var/lib/layman/xtal-prefix"
SYNC="rsync://rsync.prefix.freens.org/gentoo-portage-prefix"
USE="amd64 berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx modules mudflap ncurses nls nptl openmp pcre prefix readline session sse sse2 ssl tcpd unicode zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en_GB en sv de da fr" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7 3.3"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Johan Hattne 2013-04-24 05:03:23 UTC
Created attachment 346438 [details, diff]
Fixed embedded png image

If this looks OK to you, I can take this upstream.
Comment 2 Johan Hattne 2013-05-04 00:35:22 UTC
(In reply to comment #1)
> If this looks OK to you, I can take this upstream.

Upstream has been notified.
Comment 3 Johan Hattne 2013-05-07 15:28:40 UTC
(In reply to comment #2)
> Upstream has been notified.

Upstream has applied patch.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2014-04-08 13:15:48 UTC
(In reply to Johan Hattne from comment #1)
> Created attachment 346438 [details, diff] [details, diff]
> Fixed embedded png image

(In reply to Johan Hattne from comment #3)
> Upstream has applied patch.

+*imosflm-1.0.7-r1 (08 Apr 2014)
+
+  08 Apr 2014; Samuli Suominen <ssuominen@gentoo.org>
+  +files/1.0.7-libpng16.patch, +imosflm-1.0.7-r1.ebuild:
+  Fix broken embedded .png file for libpng16 wrt #467036 by Johan Hattne. The
+  patch has been applied also in upstream.

http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sci-chemistry/imosflm/imosflm-1.0.7-r1.ebuild?rev=1.1&content-type=text/plain
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sci-chemistry/imosflm/files/1.0.7-libpng16.patch?rev=1.1&content-type=text/plain

No idea why this bug was assigned to prefix@ instead of sci-chemistry@ but I took the liberty to reassign it as per metadata.xml and futher, apply the patch with revision bump in Portage because it has been accepted upstream.