Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 466704 - gnome-extra/zeitgeist-0.9.12: zeitgeist-datahub.c:826:6: error: ‘DOWNLOADS_MONITOR_ENABLED’ undeclared (first use in this function)
Summary: gnome-extra/zeitgeist-0.9.12: zeitgeist-datahub.c:826:6: error: ‘DOWNLOADS_MO...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Justin Lecher (RETIRED)
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-21 16:19 UTC by Juergen Rose
Modified: 2013-04-23 08:53 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
downloads-monitor patch (download_monitor.patch,588 bytes, text/plain)
2013-04-23 08:24 UTC, Evgeny Bobkin
Details
modified ebuild (zeitgeist-0.9.12.ebuild,2.08 KB, text/plain)
2013-04-23 08:25 UTC, Evgeny Bobkin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Rose 2013-04-21 16:19:40 UTC
'emerge zeitgeist' fails with:
...
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/gnome-extra/zeitgeist-0.9.12/work/zeitgeist-0.9.12/datahub -I..  -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -include ../config.h -I../libzeitgeist -w    -march=native -O2 -pipe -c zeitgeist-datahub.c
zeitgeist-datahub.c: In function ‘data_hub_start_data_providers_co’:
zeitgeist-datahub.c:826:6: error: ‘DOWNLOADS_MONITOR_ENABLED’ undeclared (first use in this function)
zeitgeist-datahub.c:826:6: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [zeitgeist-datahub.o] Error 1




root@lynx2:/usr/src(74)# emerge --info '=gnome-extra/zeitgeist-0.9.12'
Portage 2.1.11.62 (default/linux/amd64/13.0/desktop, gcc-4.7.2, glibc-2.17, 3.8.8-gentoo x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.8.8-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T7500_@_2.20GHz-with-gentoo-2.2
KiB Mem:     3972832 total,    531268 free
KiB Swap:    8008364 total,   8008220 free
Timestamp of tree: Sun, 21 Apr 2013 15:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.6, 1.12.6, 1.13.1
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.7.2-r1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo sunrise science sabayon x-portage x-cpan x-g-octave
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA PUEL Intel-SDP dlj-1.1 skype-eula skype-4.0.0.7-copyright googleearth AdobeFlash-11.x cadsoft Oracle-BCLA-JavaSE MakeMKV-EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/sunrise /var/lib/layman/science /var/lib/layman/sabayon /usr/local/portage /var/lib/cpan /var/lib/g-octave"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="64bit R X Xaw3d a52 aac acl acpi admin afs alsa amd64 ao apache2 apng applet archive armadillo arpack asf aspell assistant atlas audacious audiofile automap automount bash-completion berkdb blas blast bluetooth bluray boo boost branding bzip2 cairo cdda cddb cdf cdio cdparanoia cdr cgi chm cli consolekit corba cracklib crypt css cups curl cxx daap db dbi dbm dbus declarative designer devhelp device-mapper dga dia dirac djvu doc dot dri ds2490 ds9097 ds9097u dts dv dvb dvd dvdr dvi dynamicplugin eds egl elf emacs emboss emf encode epiphany evo examples exif expat extensions extra extras faac faad fam ffmpeg fftw firefox fits flac fltk fontconfig foomaticdb fortran fortran95 fpm fpx fts3 fuse g3dvl garmin gcj gd gdal gdbm gdu gedit geoip geolocation geos gfortran gif gimp git glade glib glpk gml gmp gnome gnome-keyring gnome-print gnuplot gnutls gold gphoto2 gpm grammar graphics graphtft graphviz grass gsl gsm gstreamer gtk gtk3 gudev guile harness hddtemp hdf hdf5 hdri html http httpd hvm hwdb iconv icq icu id3 id3tag ide imagemagick imap inotify introspection ipod ipv6 irda ithreads jabber jadetex java jbig john jpeg jpeg2k kate kde kdepim kdrive kerberos keymap kpathsea kqemu kvm ladspa lame lapack laptop latex lcms ldap lensfun libffi libkms libnotify libsamplerate lirc live lua lzo mad mail maildir mapnik math matroska media-library mercurial mikmod mkl mmx mmxext mng mod modules mono motif mozilla mp3 mp4 mpeg mpi mplayer mtp mudflap multilib musepack musicbrainz mysql mysqli nautilus ncurses netcdf netpbm network networking nfs nls nntp nptl nsplugin ntfs ntp numpy obex objc ocaml ocr octave odbc ofa ogdi ogg openexr opengl openmp overview pae pam pango pcre pda pdf perl plasma plotutils plugins png podcast policykit portaudio posix postgres postscript ppds preview-latex proj projectm projectx pstricks pulseaudio python python-bindings q32 qemu qhull qt3support qt4 quicktime raw readline reiserfs reports rhythmbox rle romio rpc rrdcgi rrdtool samba sasl schroedinger science sdk sdl secure-delete semantic-desktop server session shout sip slang slp smart smbclient smp sms sndfile snmp soap sockets sound soup sox speex spell sql sqlite sse sse2 ssl ssse3 startup-notification stlport subtitles subversion sudo suexec svg svm swig szip t1lib tcl tcpd tex tex4ht texmacs tgif theora thesaurus thinkpad threads thunderbird tidy tiff tk tools truetype udev udisks unicode upower usb userlocales utempter v4l vaapi vala vdpau video virt-network virtualbox visio vorbis vpx wav webdav webdav-serf webkit wifi wmf wxwidgets x264 xa xattr xcb xemacs xetex xext xft xine xml xmlreader xmlrpc xpm xv xvid xvmc yaml youtube zlib zvbi" ABI_X86="64" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_core authn_dbm authn_default authn_file authz_core authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgid dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info lbmethod_byrequests log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif slotmem_shm so socache_shmcb speling status unique_id unixd userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="canon fuji ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CURL_SSL="nss" DVB_CARDS="usb-wt220u" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de fr ru" NETBEANS_MODULES="apisupport cnd dlight enterprise ergonomics groovy gsf harness ide identity j2ee java mobility nb php profiler ruby websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" QEMU_SOFTMMU_TARGETS="arm i386 x86_64" QEMU_USER_TARGETS="arm i386 x86_64" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON




root@lynx2:/usr/src(75)# emerge -pqv '=gnome-extra/zeitgeist-0.9.12'
[ebuild     U ] gnome-extra/zeitgeist-0.9.12 [0.9.5-r1] USE="datahub%* dbus extensions fts icu introspection%* nls plugins -downloads-monitor% -sql-debug -telepathy% (-passiv%)" PYTHON_TARGETS="python2_7 -python2_6"
Comment 1 Kobboi 2013-04-21 18:52:39 UTC
Same here
Comment 2 Kevin Parent 2013-04-21 20:29:52 UTC
I have the same issue on funtoo current.  Compilation and installation is successful when disabling the datahub useflag.

USE="-datahub" emerge zeitgeist -1av
Comment 3 Iván Atienza 2013-04-21 23:27:31 UTC
Same here, also works with: +datahub +downloads-monitor.
Comment 4 Evgeny Bobkin 2013-04-22 12:44:53 UTC
same here and it's a shame actually that nobody even tests if the uploaded ebuild even compiles by default!!!
Comment 5 Martin Wegner 2013-04-22 13:15:41 UTC
(In reply to comment #4)
> same here and it's a shame actually that nobody even tests if the uploaded
> ebuild even compiles by default!!!

I'm sure they have tested it, but maybe with a working set of USE flags (see previous comments). I'd say it's rather impossible to test all possible combinations of (subsets of) the USE flags. And it's still testing, so don't complain about occasional bugs.
Comment 6 Evgeny Bobkin 2013-04-22 13:55:09 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > same here and it's a shame actually that nobody even tests if the uploaded
> > ebuild even compiles by default!!!
> 
> I'm sure they have tested it, but maybe with a working set of USE flags (see
> previous comments). I'd say it's rather impossible to test all possible
> combinations of (subsets of) the USE flags. And it's still testing, so don't
> complain about occasional bugs.

I suggest to you next time before writing something to think first or at least to do some research!!!

at least I looked at this ebuild file. it contains : 
IUSE="+datahub +dbus downloads-monitor extensions +fts icu introspection nls plugins sql-debug telepathy"

it means datehub is enabled by default and downloads-monitor is not.

SO as a result Martin, it will not compile by default. So, it's a shame what nobody even has tried to compile it with the default settings turned on, before bumping.

Moreover, logically all is fine. this datahub part is written in vala. and zeitgeist-datahub.vala file has a line 119, which cause an error:  
if (Config.DOWNLOADS_MONITOR_ENABLED)

additionally in  config.vapi is defined:
 public const bool DOWNLOADS_MONITOR_ENABLED;

so once downloads-monitor is not enabled, then DOWNLOADS_MONITOR_ENABLED does not exist in C but in vala!!!

So one of the solutions is probably to modify configure.ac from line 190-193, I looked at trunk by defining DOWNLOADS_MONITOR_ENABLED with 0, if it is not enabled.

like :

if test "x$enable_downloads_monitor" = "xyes" -a "x$enable_datahub" = "xyes"; then
    AC_DEFINE([DOWNLOADS_MONITOR_ENABLED], [1], [Is the XDG_DOWNLOAD_DIRECTORY file monitor enabled?])
else
    AC_DEFINE([DOWNLOADS_MONITOR_ENABLED], [0], [Is the XDG_DOWNLOAD_DIRECTORY file monitor enabled?])
fi
Comment 7 Rolf S. Arvidson 2013-04-22 16:09:58 UTC
(In reply to comment #3)
> Same here, also works with: +datahub +downloads-monitor.

Thanks Iván (and evgenn), enabling downloads-monitor solved this for me.
Comment 8 Pacho Ramos gentoo-dev 2013-04-22 20:02:20 UTC
Just hit
Comment 9 David 2013-04-23 00:13:48 UTC
(In reply to comment #7)
> (In reply to comment #3)
> > Same here, also works with: +datahub +downloads-monitor.
> 
> Thanks Iván (and evgenn), enabling downloads-monitor solved this for me.


Enabling the downloads-monitor use flag works for me also.
Comment 10 Justin Lecher (RETIRED) gentoo-dev 2013-04-23 05:57:09 UTC
+  23 Apr 2013; Justin Lecher <jlec@gentoo.org> zeitgeist-0.9.12.ebuild:
+  Fix typo, #466704
+
Comment 11 Evgeny Bobkin 2013-04-23 08:23:48 UTC
(In reply to comment #10)
> +  23 Apr 2013; Justin Lecher <jlec@gentoo.org> zeitgeist-0.9.12.ebuild:
> +  Fix typo, #466704
> +

Thank you for the fix.

now, it compiles fine, under default settings, but is it correct?

should not it be otherwise? because downloads-monitor is one of the providers of hatahub. so, I think it should be:

REQUIRED_USE="downloads-monitor? ( datahub )"

moreover, in combination with the comment 6 a patch is required!
Comment 12 Evgeny Bobkin 2013-04-23 08:24:30 UTC
Created attachment 346352 [details]
downloads-monitor patch
Comment 13 Evgeny Bobkin 2013-04-23 08:25:36 UTC
Created attachment 346354 [details]
modified ebuild
Comment 14 Justin Lecher (RETIRED) gentoo-dev 2013-04-23 08:53:33 UTC
+  23 Apr 2013; Justin Lecher <jlec@gentoo.org> zeitgeist-0.9.12.ebuild,
+  +files/zeitgeist-0.9.12-download_monitor.patch:
+  Fix buildsystem to correctly handle --enable-downloads-monitor, thanks evgenn
+  for the patch; correct REQUIRED_USE logic
+