Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 466248 - media-libs/lcms-1.19-r1 ported to eapi5 and python-r1
Summary: media-libs/lcms-1.19-r1 ported to eapi5 and python-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 466278
  Show dependency tree
 
Reported: 2013-04-17 14:59 UTC by Nikoli
Modified: 2013-05-05 21:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lcms-1.19-r1.ebuild: (lcms-1.19-r1.ebuild,2.25 KB, text/plain)
2013-04-17 14:59 UTC, Nikoli
Details
lcms-1.19-r1.ebuild (lcms-1.19-r1.ebuild,2.44 KB, text/plain)
2013-04-17 17:36 UTC, Maxim Koltsov (RETIRED)
Details
lcms-1.19-r2.ebuild (lcms-1.19-r2.ebuild,3.13 KB, text/plain)
2013-04-17 20:28 UTC, Maxim Koltsov (RETIRED)
Details
lcms-1.19-fix-swig-destructor.patch (lcms-1.19-fix-swig-destructor.patch,345 bytes, patch)
2013-04-18 18:33 UTC, Maxim Koltsov (RETIRED)
Details | Diff
lcms-1.19-fix-python3.2.patch (lcms-1.19-fix-python3.2.patch,1.07 KB, text/plain)
2013-04-18 18:34 UTC, Maxim Koltsov (RETIRED)
Details
Updated ebuild (lcms-1.19-r1.ebuild,2.43 KB, text/plain)
2013-04-18 19:31 UTC, Michał Górny
Details
ebuild (lcms-1.19-r1.ebuild,2.54 KB, text/plain)
2013-04-19 11:22 UTC, Nikoli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-04-17 14:59:44 UTC
Created attachment 345792 [details]
lcms-1.19-r1.ebuild:

Ported media-libs/lcms:0 to EAPI5 and python-single-r1.eclass, please commit. Ebuild works fine here, installed files are same. Python team, please check if ebuild was ported correctly.
Comment 1 Maxim Koltsov (RETIRED) gentoo-dev 2013-04-17 17:36:25 UTC
Created attachment 345814 [details]
lcms-1.19-r1.ebuild

Reviewed version of ebuild: ported to autotools-utils eclass. Multiple python support is rather difficult, but if @printing request it, we will work on it.
Comment 2 Maxim Koltsov (RETIRED) gentoo-dev 2013-04-17 20:28:04 UTC
Created attachment 345826 [details]
lcms-1.19-r2.ebuild

This is multipython version. The only one problem is that it can't build correctly for both python2 & 3 --- this has to be checked.
Comment 3 Maxim Koltsov (RETIRED) gentoo-dev 2013-04-18 18:33:49 UTC
Created attachment 345928 [details, diff]
lcms-1.19-fix-swig-destructor.patch

Patch for swig lcms.i file
Comment 4 Maxim Koltsov (RETIRED) gentoo-dev 2013-04-18 18:34:16 UTC
Created attachment 345930 [details]
lcms-1.19-fix-python3.2.patch

Patch for python3 support
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-04-18 19:31:33 UTC
Created attachment 345940 [details]
Updated ebuild

This is the best and simplest thing I can make of it.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-04-18 19:40:43 UTC
(In reply to comment #5)
> Created attachment 345940 [details]
> Updated ebuild
> 
> This is the best and simplest thing I can make of it.

Plus eutils and multilib inherits can probably be dropped.
Comment 7 Nikoli 2013-04-19 11:22:37 UTC
Created attachment 346016 [details]
ebuild

Fixed tests and docs, removed eutils and multilib from inherit.
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2013-05-05 21:03:52 UTC
Committet. 

@ maksobotan, mgorny, python team:

1) given the level of complexity introduced by the python stuff here, I have taken the liberty of adding python herd to the maintainers of lcms.

2) in the future, if you want someone else to commit fixes, please leave comments what the stuff does. the swig patch is a mystery to me, trusting maksobotan here.