Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46567 - QA gnome-base/gnome-vfs-1.0.5-r3gnome-base/gnome-vfs-2.4.2-r1 installs to /usr/doc instead on /usr/share/doc
Summary: QA gnome-base/gnome-vfs-1.0.5-r3gnome-base/gnome-vfs-2.4.2-r1 installs to /us...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All All
: Lowest trivial
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-02 01:01 UTC by Daniel Black (RETIRED)
Modified: 2004-08-08 06:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-vfs.patch (gnome-vfs.patch,354 bytes, patch)
2004-04-02 16:22 UTC, Daniel Black (RETIRED)
Details | Diff
gnome-vfs-2.4*.patch (gnome-vfs-2.4.2.patch,1.34 KB, patch)
2004-04-19 00:22 UTC, Daniel Black (RETIRED)
Details | Diff
gnome-vfs-2.6.patch (gnome-vfs-2.6.patch,1.62 KB, patch)
2004-04-19 00:35 UTC, Daniel Black (RETIRED)
Details | Diff
gnome-vfs-devel-docs-2.6.0.patch (gnome-vfs-devel-docs-2.6.0.patch,308 bytes, patch)
2004-04-19 05:57 UTC, Daniel Black (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Black (RETIRED) gentoo-dev 2004-04-02 01:01:22 UTC
qpkg -f  /usr/doc -v

gnome-base/gnome-vfs-1.0.5-r3 *
gnome-base/gnome-vfs-2.4.2-r1 *
Comment 1 foser (RETIRED) gentoo-dev 2004-04-02 02:25:12 UTC
there's nothing in there ? Again i have to question the use of reporting/fixing these non-problems.

It's probably the makefile that has a hardcoded path somewhere, give us a patch and we'll put it in.
Comment 2 Daniel Black (RETIRED) gentoo-dev 2004-04-02 16:22:43 UTC
Created attachment 28601 [details, diff]
gnome-vfs.patch

Your quite right - they are empty directories. Attached is the patch anyway.
Works for the two versions listed. Probably will work for others (with
potential patch offset).
Comment 3 foser (RETIRED) gentoo-dev 2004-04-02 16:45:00 UTC
c'mon qa, you want $(datadir) there not $(prefix)/share . And if this dir is always empty -not used- it should probably just stop creating the dir.
Comment 4 Daniel Black (RETIRED) gentoo-dev 2004-04-02 17:08:04 UTC
yep your right - at least you know where its coming from now.
Comment 5 Daniel Black (RETIRED) gentoo-dev 2004-04-19 00:22:28 UTC
Created attachment 29596 [details, diff]
gnome-vfs-2.4*.patch

Works for gnome-vfs-2.4.2-r1 gnome-vfs-2.4.1 and gnome-vfs-2.4.0
Comment 6 Daniel Black (RETIRED) gentoo-dev 2004-04-19 00:35:13 UTC
Created attachment 29597 [details, diff]
gnome-vfs-2.6.patch

If these patches are good enough can you let me know so they can be sumbitted
upstream. If you want to submit them upstream yourself that is also fine with
me.
Comment 7 foser (RETIRED) gentoo-dev 2004-04-19 02:14:56 UTC
Makefile.in is a generated file, you should patch Makefile.am here to push it upstream. Looking at it (Makefile.am), the fix seems obvious and it's docdir statement should be $(datadir)/doc . But we might as well suggest removing the devel-docs dir i think, it seems obsolete.

If that fix goes upstream we might as well fix the gentoo ebuilds the easy way for now and remove ${D}/usr/doc in src_install . I personally don't really care much about fixing it for older versions, it will eventually die out.
Comment 8 Daniel Black (RETIRED) gentoo-dev 2004-04-19 05:57:39 UTC
Created attachment 29613 [details, diff]
gnome-vfs-devel-docs-2.6.0.patch

Sound good to me - patch here in case upstream wants to keep devel-docs for
reasons best known to themselves
Comment 9 foser (RETIRED) gentoo-dev 2004-04-19 09:20:38 UTC
my proposed workaround I added to the 1.0.5-r3 & 2.6.1 ebuild.

Please push the makefile fix upstream (leave the link here). But i'd suggest to move the devel-docs dir to the attic as well as possible solution.
Comment 10 Daniel Black (RETIRED) gentoo-dev 2004-08-08 06:49:29 UTC
gnome-vfs-2.6.1.1 doesn't have it and the rest can die out. And version 1.0.5 has been fixed.