Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46544 - mozilla-launcher could/should start mozilla-thunderbird too
Summary: mozilla-launcher could/should start mozilla-thunderbird too
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 45367
  Show dependency tree
 
Reported: 2004-04-01 17:09 UTC by Mike Auty (RETIRED)
Modified: 2004-05-04 13:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes mozilla-launcher to include rudimentry thunderbird support (mozilla-launcher-1.2.patch,1.52 KB, patch)
2004-04-01 17:15 UTC, Mike Auty (RETIRED)
Details | Diff
Updated patch to fix $u evaluation problem (mozilla-launcher-1.2-patch2.patch,1.53 KB, patch)
2004-04-01 17:42 UTC, Mike Auty (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2004-04-01 17:09:45 UTC
The new mozilla-launcher package, could be adapted to support starting mozilla-thunderbird also.  This also would automatically add support for detecting running instances of thunderbird, solving bug 45367.  It would also unify all mozilla startup scripts, and make centralized changes to mozilla-xremote-client easy to fix.
Comment 1 Mike Auty (RETIRED) gentoo-dev 2004-04-01 17:15:11 UTC
Created attachment 28541 [details, diff]
Fixes mozilla-launcher to include rudimentry thunderbird support

Attached is a patch that adds rudimentary thunderbird support.	Note that it
will open a new thunderbird window, or attempt to raise the existing one.

This hasn't been tested over multiple desktops (in fact, I'm not sure how that
ought to work, so I'll let someone else figure it out).

It also does not yet handle URLs, so thunderbird junk@yahoo.com simply ignores
the address.

It may also break running mozillas with multiple URLs because $u may get
evaluated in the which_browser function, rather than when it is intended to be
used.  I don't know enough bash scripting to help me delay it's evaluation. 
Any help would be appreciated.

Finally this also includes a small workaround for mozilla programs, in that it
removes the space between the comma and the new-{$newtype} command.  This is a
bug in mozilla, and is documented as Mozillabug 229681.  It seems to have gone
unnoticed by the mozilla developers, if anyone can bring it to their attention
that would also be nice.  5:)
Comment 2 Mike Auty (RETIRED) gentoo-dev 2004-04-01 17:18:04 UTC
Sorry, I just realised the patch may not apply cleanly to the original version of mozilla-launcher because I had already included the workaround for mozillabug 229681 when I made the diff.  Sorry about that.  It should be easy to see how to rectify it, so it does apply cleanly.
Comment 3 Mike Auty (RETIRED) gentoo-dev 2004-04-01 17:42:26 UTC
Created attachment 28543 [details, diff]
Updated patch to fix $u evaluation problem

Fixed patch that now applies directly to original mozilla-launcher-1.2, and
includes a fix to ensure that the $u term is evalutated when needed, not during
which_browser.	Figured I didn't need to do the same for new-type since that
gets set once at the top and doesn't get changed.
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2004-04-01 20:50:48 UTC
Thanks Mike.  I wrote mozilla-launcher, but I haven't used thunderbird before.  I'll take a look at your suggestions and hopefully get something out soon.
Comment 5 Radoslaw Szkodzinski 2004-04-09 18:25:46 UTC
Seems I've done some redundant work:

Could you also make Thunderbird handle multiple mailto's,
like I did in my modified script?

I haven't done it in an universal way, but... it works.
Comment 6 Aron Griffis (RETIRED) gentoo-dev 2004-04-26 08:28:55 UTC
Sorry I haven't gotten to this yet, I hope to soon
Comment 7 Aron Griffis (RETIRED) gentoo-dev 2004-05-04 13:44:27 UTC
Thanks guys.  All set in thunderbird-0.6-r1 and mozilla-launcher-1.6