Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464558 - www-apps/tt-rss 1.7.8 version bump and ebuild correction
Summary: www-apps/tt-rss 1.7.8 version bump and ebuild correction
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Markos Chandras (RETIRED)
URL: http://tt-rss.org/redmine/versions/90
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 09:59 UTC by Patrick
Modified: 2013-04-06 07:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove second level subdirs (cache/*) from ebuild and init script (remove_second-level-subdirs.patch,1.72 KB, patch)
2013-04-06 03:38 UTC, Patrick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick 2013-04-04 09:59:18 UTC
First I'd like to thank scarabeus for improving the ebuild, and submitting the last two version bumps! :)

scarabeus, you made one change that causes slight breakage - using '-R' for the webapp_serverowned call somehow doesn't work, and then the sub-directories cache/images cache/export end up not being server-owned, resulting in the webapp reporting that it can't write to those cache directories. Just removing the '-R' from line 64 fixes the issue.

I'm aware that 1.7.8 was released just today (as were 1.7.7 and 1.7.6 - call that rapid development ;)

I verified that it works without any other changes to the ebuild or init scripts necessary.

Reproducible: Always
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2013-04-04 10:47:46 UTC
Darn, sorry about that.
Workaround for the owning issue is to change conf.d/ttrssd to set group/user as the webserver.

Also the 1.7.7 and 1.7.8 seems to contain just triv updates so what should we do. Full bump now and update the initscript when we have solution, or fix the initscript first and then bump?
Comment 2 Patrick 2013-04-04 12:24:57 UTC
(In reply to comment #1)
> Workaround for the owning issue is to change conf.d/ttrssd to set group/user
> as the webserver.

That could be done, yes.

> Also the 1.7.7 and 1.7.8 seems to contain just triv updates so what should
> we do. Full bump now and update the initscript when we have solution, or fix
> the initscript first and then bump?

Why not just change the ebuild (remove -R from the webapp_serverowned call) and bump to 1.7.8 at the same time? Am I missing something?
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2013-04-04 12:54:57 UTC
The problem is that it should be really recursive, because the daemon update even the inner stuff (favicons/etc) when needed from what I observed.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2013-04-05 20:17:52 UTC
(In reply to comment #1)
> Darn, sorry about that.
> Workaround for the owning issue is to change conf.d/ttrssd to set group/user
> as the webserver.
> 
> Also the 1.7.7 and 1.7.8 seems to contain just triv updates so what should
> we do. Full bump now and update the initscript when we have solution, or fix
> the initscript first and then bump?

My preference is to fix the script then bump
Comment 5 Patrick 2013-04-06 03:38:46 UTC
Created attachment 344588 [details, diff]
Remove second level subdirs (cache/*) from ebuild and init script

Ok, I've done some experiments:

webapp_serverowned -R works fine if the parameter is a simple directory, but if the parameter is a path with a directory separator in it, the directory ends up owned by root, even if it was owned by apache before. I don't think that's expected behaviour, and it should probably be changed.

For this specific case I found a simple solution: We just remove the cache/* sub-directories, and the problem is solved.

IMO we can apply this and bump to 1.7.8 directly - works for me.
Comment 6 Tomáš Chvátal (RETIRED) gentoo-dev 2013-04-06 07:40:27 UTC
Good patch, thanks for investigating. The patch has been added to cvs.