Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464034 - dev-embedded/pk2cmd-1.21rc1 - Version bump.
Summary: dev-embedded/pk2cmd-1.21rc1 - Version bump.
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2013-04-01 03:53 UTC by Joe M
Modified: 2016-08-06 08:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (pk2cmd-1.21_rc1.ebuild,1.94 KB, text/plain)
2013-04-01 03:53 UTC, Joe M
Details
patch for device file path (pk2cmd-add-share-dir-for-dev-file-1.21_rc1.patch,668 bytes, text/plain)
2013-04-01 03:54 UTC, Joe M
Details
pk2cmd-1.21_rc1.ebuild (pk2cmd-1.21_rc1.ebuild,2.17 KB, text/plain)
2014-08-19 15:22 UTC, Joe M
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joe M 2013-04-01 03:53:58 UTC
Created attachment 343880 [details]
ebuild

ebuild for pk2cmd 1.21rc1
Comment 1 Joe M 2013-04-01 03:54:25 UTC
Created attachment 343882 [details]
patch for device file path
Comment 2 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-08-01 22:02:03 UTC
Comment on attachment 343880 [details]
ebuild

Your ebuild is wrong. I am did not look deep, but:

a.) wrong obsolete copyright (minor, but just for note)
b.) SRC_URI pulls zip archive, so app-arch/unzip should be in DEPEND at least
c.) are you sure about ${S} ? ;)
d.) src_unpack for preparing sources in EAPI=5, really? ;)
e.) sed should use || die 
.....
so on
Comment 3 Joe M 2014-08-19 15:22:33 UTC
Created attachment 383130 [details]
pk2cmd-1.21_rc1.ebuild
Comment 4 Joe M 2014-08-19 15:25:12 UTC
Hello Mikle Kolyada,

Thanks for your comments.

> a.) wrong obsolete copyright (minor, but just for note)
corrected.

> b.) SRC_URI pulls zip archive, so app-arch/unzip should be in DEPEND at least
added

> c.) are you sure about ${S} ? ;)
not sure which line this is from?

> d.) src_unpack for preparing sources in EAPI=5, really? ;)
I am not experienced enough to know any better. Any help, please?

> e.) sed should use || die 
added

Attached is the modified ebuild.

Thanks
Joe