Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 463978 - net-proxy/dansguardian-2.12.0.3 USE="-debug" has no effect
Summary: net-proxy/dansguardian-2.12.0.3 USE="-debug" has no effect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 10:48 UTC by Tomáš Mózes
Modified: 2013-04-01 19:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2013-03-31 10:48:10 UTC
The "-debug" USE flag has no effect on disabling debugging.

USE="debug"
 * USE:        amd64 backtrace clamav debug elibc_glibc fancydm kernel_linux lfs logrotate orig-ip pcre trickledm userland_GNU
 * FEATURES:   sandbox
>>> Unpacking source...
>>> Unpacking dansguardian-2.12.0.3.tar.bz2 to /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work
>>> Source unpacked in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work
>>> Preparing source in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work/dansguardian-2.12.0.3 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work/dansguardian-2.12.0.3 ...
 * econf: updating dansguardian-2.12.0.3/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating dansguardian-2.12.0.3/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --disable-avastd --enable-segv-backtrace --enable-clamd --disable-commandline --with-dgdebug --disable-email --enable-fancydm --disable-icap --disable-kavd --enable-lfs --with-logdir=/var/log/dansguardian --disable-ntlm --enable-orig-ip --enable-pcre --with-piddir=/var/run --with-proxygroup=dansguardian --with-proxyuser=dansguardian --disable-static-zlib --enable-trickledm
...
checking for debug option... yes


USE="-debug"
 * USE:        amd64 backtrace clamav elibc_glibc fancydm kernel_linux lfs logrotate orig-ip pcre trickledm userland_GNU
 * FEATURES:   sandbox
>>> Unpacking source...
>>> Unpacking dansguardian-2.12.0.3.tar.bz2 to /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work
>>> Source unpacked in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work
>>> Preparing source in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work/dansguardian-2.12.0.3 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-proxy/dansguardian-2.12.0.3/work/dansguardian-2.12.0.3 ...
 * econf: updating dansguardian-2.12.0.3/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating dansguardian-2.12.0.3/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --disable-avastd --enable-segv-backtrace --enable-clamd --disable-commandline --without-dgdebug --disable-email --enable-fancydm --disable-icap --disable-kavd --enable-lfs --with-logdir=/var/log/dansguardian --disable-ntlm --enable-orig-ip --enable-pcre --with-piddir=/var/run --with-proxygroup=dansguardian --with-proxyuser=dansguardian --disable-static-zlib --enable-trickledm
...
checking for debug option... yes

Implications when used in production environment:
- the log full of "dansguardian: Served x requests on this connection so far" messages
- ContentScanner.cpp:

#ifndef DGDEBUG
        unlink(tempfilepath.toCharArray());  // delete temp file
#endif

when combined with clamd, the /tmp directory is filled with /tmp/tf* temporary files (files created to be scanned with clamd).

The configure script defines:
  --with-dgdebug[=off]    switch on debug build mode

When compiled without the debug flag however, we set --without-dgdebug and it has no effect. A possible fix:

--- /usr/portage/net-proxy/dansguardian/dansguardian-2.12.0.3.ebuild    2013-03-04 12:13:11.000000000 +0000
+++ dansguardian-2.12.0.3-r1.ebuild     2013-03-30 17:10:38.942975806 +0000
@@ -31,12 +31,17 @@
 }

 src_configure() {
+       local debug
+       if use debug; then
+               debug="$(use_with debug dgdebug)"
+       fi
+
        econf \
                $(use_enable avast avastd) \
                $(use_enable backtrace segv-backtrace) \
                $(use_enable clamav clamd) \
                $(use_enable commandline) \
-               $(use_with debug dgdebug) \
+               $debug \
                $(use_enable email) \
                $(use_enable fancydm) \
                $(use_enable icap) \
Comment 1 Tomáš Mózes 2013-03-31 10:49:30 UTC
Portage 2.1.11.55 (hardened/linux/amd64, gcc-4.5.4, glibc-2.15-r3, 3.7.5-hardened x86_64)
=================================================================
System uname: Linux-3.7.5-hardened-x86_64-Intel-R-_Xeon-R-_CPU_X5680_@_3.33GHz-with-gentoo-2.1
KiB Mem:     6112652 total,   1062936 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Sun, 31 Mar 2013 10:15:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.69
sys-devel/automake:       1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo x-hydra
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch xattr"
FFLAGS="-O2 -pipe"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/hydra"
USE="acl amd64 berkdb bzip2 cli cracklib crypt cxx dri gdbm gpm hardened iconv justify mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre readline session sse sse2 ssl tcpd unicode urandom xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authz_host dir mime log_config log_forensic alias actions status info rewrite auth_digest authn_file authn_core authz_user authz_core unixd socache_shmcb" APACHE2_MPMS="event" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-01 10:28:58 UTC
Thank you for reporting, a revision bump will resolve this:

> checking for debug option... no

+  01 Apr 2013; Tom Wijsman <TomWij@gentoo.org> +dansguardian-2.12.0.3-r1.ebuild:
+  Revision bump. Package was forcing debug on everyone, resolved by only passing
+  debug parameter to econf when USE="debug". Reported by Tomas Mozen. Fixes bug
+  #463978.
Comment 3 Tomáš Mózes 2013-04-01 19:26:57 UTC
Thanks for the bump Tom