Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 463362 - app-backup/rdiff-backup enables xattr support even if USE="-xattr" is set, so long as dev-python/pyxattr is installed.
Summary: app-backup/rdiff-backup enables xattr support even if USE="-xattr" is set, so...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alex Brandt (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 13:23 UTC by Philippe Chaintreuil
Modified: 2015-04-18 15:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild with unconditional deps (rdiff-backup-1.3.3-r1.ebuild,587 bytes, text/plain)
2014-04-24 12:59 UTC, Michael Orlitzky
Details
Updated ebuild with unconditional deps (rdiff-backup-1.3.3-r1.ebuild,587 bytes, text/plain)
2014-04-25 16:56 UTC, Michael Orlitzky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Chaintreuil 2013-03-26 13:23:05 UTC
The hardened profile has forced xattr on sys-apps/portage which installs dev-python/pyxattr.  The existence of this package enables xattr support in app-backup/rdiff-backup, even if USE="-xattr" is set.  rdiff-backup will throw a warning that xattr information just suddenly showed up.

Reproducible: Always



Expected Results:  
Not quiet sure how blocking can be specified, but dev-python/pyxattr should probably be blocked by rdiff-backup if -xattr is detected.  Mostly to force the user to decide what they want to do.

This came out of bug #462942, which has more backstory.
Comment 1 Michael Orlitzky gentoo-dev 2014-04-24 12:59:08 UTC
Created attachment 375610 [details]
Updated ebuild with unconditional deps

There's no good solution for this -- we don't have a way to pass flags from build time to runtime, so we can't tell rdiff-backup to disable something based on a USE flag that was set at build time. The blocker idea also won't fly because the user can't fix a blocker on his own.

The usual suggested approach is to mention the optional dependencies in an elog at postinst. However, in this case, I think it's better to make the deps unconditional. Yes, you'll get the warning that you mentioned. But the alternative, if we just suggest pylibacl and pyxattr in an elog, is worse: the user might accidentally remove one of them and trash his backups when they get overwritten without ACLs.

So, I've updated the ebuild with unconditional deps. I also did an eclass/eapi bump, and added two extra docs.
Comment 2 Michael Orlitzky gentoo-dev 2014-04-25 16:56:19 UTC
Created attachment 375702 [details]
Updated ebuild with unconditional deps

Might as well put the deps in RDEPEND where they belong.
Comment 3 Alex Brandt (RETIRED) gentoo-dev 2015-04-14 15:17:02 UTC
Sorry this is late.  Finally got a couple moments of spare time to really look at this.  Creating a bump ebuild in my overlay for feedback.  Investigating the inclusion of this patch.
Comment 4 Alex Brandt (RETIRED) gentoo-dev 2015-04-14 15:55:04 UTC
Alright, I've incorporated these changes into the copy on my overlay.  Installation succeeds but there is no test to suite to verify any deeper.  Does anyone mind corroborating that the overlay version is acceptable?
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-04-15 04:26:27 UTC
I back that up
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-04-16 07:59:22 UTC
package installs and appears to work fine run time
Comment 7 Alex Brandt (RETIRED) gentoo-dev 2015-04-18 15:07:26 UTC
Alright, added these changes to the tree.  Lifting the mask and in thirty days will request this bump to be stabilized.