Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 462562 - sys-kernel/genkernel: add nconfig support.
Summary: sys-kernel/genkernel: add nconfig support.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-03-21 05:32 UTC by Vadim A. Misbakh-Soloviov (mva)
Modified: 2017-01-02 23:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
nconfig.patch (nconfig.patch,3.51 KB, patch)
2013-03-21 10:53 UTC, Vadim A. Misbakh-Soloviov (mva)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-03-21 05:32:25 UTC
Is it possible to add support for nconfig as it already present for menuconfig?

Reproducible: Always
Comment 1 Richard Yao (RETIRED) gentoo-dev 2013-03-21 09:21:02 UTC
Sure. Do you have a patch for us?
Comment 2 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-03-21 10:53:43 UTC
Created attachment 342836 [details, diff]
nconfig.patch

(In reply to comment #1)
> Sure. Do you have a patch for us?

Yes. But to be honest, it is just a bit of copypaste work.
Comment 3 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-03-21 10:55:12 UTC
btw, this patch is made against genkernel-3.4.45; Maybe, I'll need to do one more against 9999 (but I can't get it to build).
Comment 4 Xake 2013-03-21 14:47:35 UTC
Comment on attachment 342836 [details, diff]
nconfig.patch

>-  echo '	--menuconfig		Run menuconfig after oldconfig'
>+  echo '	--menuconfig		Run menuconfig after oldconfig, or:'


Please do not change this.
Comment 5 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2013-03-21 17:50:13 UTC
(In reply to comment #4)
> Comment on attachment 342836 [details, diff] [details, diff]
> nconfig.patch
> 
> >-  echo '	--menuconfig		Run menuconfig after oldconfig'
> >+  echo '	--menuconfig		Run menuconfig after oldconfig, or:'
> 
> 
> Please do not change this.

why?
Comment 6 Xake 2013-03-23 07:02:21 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 342836 [details, diff] [details, diff] [details, diff]
> > nconfig.patch
> > 
> > >-  echo '	--menuconfig		Run menuconfig after oldconfig'
> > >+  echo '	--menuconfig		Run menuconfig after oldconfig, or:'
> > 
> > 
> > Please do not change this.
> 
> why?

I could ask you the same. Why should we add "or" there?

Adding the "or" changes the current style of the "--help" text, but also adds ordering of the flags which tbh i do not like, as at least creates one more thing to think about when you mess around in the code.
Comment 7 Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2016-10-15 08:02:42 UTC
ping?

// And, if any, I ACKing removing ", or:" from menuconfig line
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-01-02 23:08:50 UTC
[master 8de563b] Implement kernel nconfig just like menuconfig.
 Author: Vadim A. Misbakh-Soloviov (mva) <gentoo@mva.name>
 Date: Mon Jan 2 15:08:07 2017 -0800
 4 files changed, 31 insertions(+)