Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46245 - k3b postinst message is bad
Summary: k3b postinst message is bad
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Heinrich Wendel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-30 07:57 UTC by David Grant
Modified: 2004-04-06 14:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Grant 2004-03-30 07:57:18 UTC
if use kde; then
        einfo "The k3b setup program will offer to change some permissions and"
        einfo "create a user group.  These changes are not necessary.  We recommend"
        einfo "that you clear the two check boxes that 'let k3b make changes for"
        einfo "cdrecord and cdrdao' and 'let k3b make changes for the devices when"
        einfo "running k3b setup'."
    fi

This message is bad for many reasons.

-It is unclear whether we should let k3b make changes for the devices, in the way it is currently worded.
-It does not say what to do about the "CD burning group" checkbox
-Why is the user told this only if they have the kde USE flag enabled?  Makes no sense at all.
-It does not suggest any alternatives.
-Without making the permission changes to cdrecord, I can get buffer underruns because my normal user can't set priority on cdrecord process.
Comment 1 Heinrich Wendel (RETIRED) gentoo-dev 2004-03-30 08:25:05 UTC
So make a better proposal ;)

It is only told when kde is in useflags because otherwise k3bsetup will not be installed.
Comment 2 David Grant 2004-03-30 08:44:41 UTC
Suggestions:

-k3bsetup should be installed no matter what.  Why not?

This:

"We recommend that you clear the two check boxes that 'let k3b make changes for cdrecord and cdrdao' and 'let k3b make changes for the devices when running k3b setup'."

should be changed to:

"We recommend that you clear the two check boxes that lets 'k3b make changes for cdrecord and cdrdao' and clear the checkbox that lets 'k3b make changes for the devices when running k3b setup'."

or:

"We recommend that you clear the two check boxes that let 'k3b make changes for cdrecord and cdrdao' but leave the checkbox checked to let 'k3b make changes for the devices when running k3b setup'."

(note the different location of the single-quotation marks)

..depending on what meaning that is intended (I'm not sure which was intended)

-something should be said about the cdrw group creation.  Is it needed or not?

-a more convincing reason should be given as to WHY the user should not run k3bsetup.  "These changes are not necessary" is not convincing for me, as it turns out, in my opinion, that these changes ARE necessary.


Comment 3 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-01 00:23:51 UTC
What about a solution that does not mention k3bsetup (for both +kde and -kde).
Something like:

Note that k3b will report problems regarding the permissions of cdrecord and cdrdao, and will suggest some changes for your system. You are free to follow
those advices, note nonetheless that on a default Gentoo install k3b should
run fine even without any change.
Comment 4 David Grant 2004-04-01 09:26:20 UTC
"default Gentoo install k3b should run fine even without any change."

Can you back up this statement?  How do you define "fine"?
Comment 5 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-01 15:18:41 UTC
Well, it worked fine for me. The permissions of the devices are handled by PAM, so I didn't bothered.
Making cdrecord and cdrdao setuid to prevent buffer underruns is just one of 
the many actions that could be taken to resolve specific troubles, I would 
consider it mandatory only if lack of the setuid bit always caused problems, 
and problems arise only on few installations.
Comment 6 David Grant 2004-04-01 15:55:20 UTC
k3b doesn't use PAM does it?
Comment 7 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-02 01:29:59 UTC
No, I simply meant that PAM gives you ownership of the devices when you login.
Comment 8 Heinrich Wendel (RETIRED) gentoo-dev 2004-04-05 07:44:43 UTC
how does pam do this?
Comment 9 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-05 13:54:47 UTC
In /etc/pam.d/login or in other files (e.g. /etc/pam.d/kde
if you use kdm) one line referes to the module pam_console.so.
That module reads from /etc/security/console.perms and sets
permissions to devices accordingly (see 'man pam_console').

I thought that this behaviour was the default for every gentoo box,
but I can be wrong. If that's not true, then definitively there needs
to be a note about the permissions of the cdr devices.
Comment 10 Heinrich Wendel (RETIRED) gentoo-dev 2004-04-06 05:27:33 UTC
ok, verified that.

i changed the message to 

    einfo "Note that k3b will report problems regarding the permissions of cdrecord"
    einfo "and cdrdao, and will suggest some changes for your system. You are free"
    einfo "to follow those devices, note nonetheless that on a default Gentoo install"
    einfo "k3b should run fine when you are in the cdrom and cdrw group."

in k3b-0.11.9
Comment 11 Gregorio Guidi (RETIRED) gentoo-dev 2004-04-06 14:05:18 UTC
It's 'follow those advices' instead of 'follow those devices'? ;)

Thanks for your time!
Comment 12 Heinrich Wendel (RETIRED) gentoo-dev 2004-04-06 14:15:01 UTC
jep, fixed :)