Bug 462440 – media-gfx/fbgrab: ebuild improvement

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mikle Kolyada (RETIRED) 2013-03-20 08:32:43 UTC]

Created attachment 342696 [details]
fbgrab-1.0-r1.ebuild

Ebuild was bumped to EAPI=5 (i also drop '-g' flag from build system). And i have attached updated patch for zlib.

@proxy-maintainers, i will take care of that.

[Comment 1 Mikle Kolyada (RETIRED) 2013-03-20 08:33:47 UTC]

Created attachment 342700 [details, diff]
fbgrab-zlib_h.patch

[Comment 2 Markos Chandras (RETIRED) 2013-03-21 21:27:43 UTC]

I see no reason to have 2 zlib_h patches. I dropped the old one and renamed this one to fbgrab-1.0-zlib_h.patch

+*fbgrab-1.0-r1 (21 Mar 2013)
+
+  21 Mar 2013; Markos Chandras <[e-mail]> +fbgrab-1.0-r1.ebuild,
+  files/fbgrab-1.0-zlib_h.patch, metadata.xml:
+  Revbump for cleanup and update zlib_h patch. Bug #462440. Mikle Zlogene
+  Kolyada will maintain it.
+

[Comment 3 Markos Chandras (RETIRED) 2013-03-22 10:20:52 UTC]

(In reply to comment #1)
> Created attachment 342700 [details, diff] [details, diff]
> fbgrab-zlib_h.patch

This patch is wrong? Why did you change the old one? zlib.h must be included before png.h. I will revert it tonight

[Comment 4 Mikle Kolyada (RETIRED) 2013-03-22 10:46:23 UTC]

(In reply to comment #3)
> (In reply to comment #1)
> > Created attachment 342700 [details, diff] [details, diff] [details, diff]
> > fbgrab-zlib_h.patch
> 
> This patch is wrong? Why did you change the old one? zlib.h must be included
> before png.h. I will revert it tonight

I can't  apply the old patch, when i try do it i getting "No file to patch. Skipping patch" i don't know why. But new patch works fine by me.

[Comment 5 Markos Chandras (RETIRED) 2013-03-22 10:49:54 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > > Created attachment 342700 [details, diff] [details, diff] [details, diff] [details, diff]
> > > fbgrab-zlib_h.patch
> > 
> > This patch is wrong? Why did you change the old one? zlib.h must be included
> > before png.h. I will revert it tonight
> 
> I can't  apply the old patch, when i try do it i getting "No file to patch.
> Skipping patch" i don't know why. But new patch works fine by me.

I don't understand what this means to be honest. The same patch applies to both ebuilds since the source code is the same. Anyway the old patch needs to be restored anyway

[Comment 6 Mikle Kolyada (RETIRED) 2013-03-22 10:59:00 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #1)
> > > > Created attachment 342700 [details, diff] [details, diff] [details, diff] [details, diff] [details, diff]
> > > > fbgrab-zlib_h.patch
> > > 
> > > This patch is wrong? Why did you change the old one? zlib.h must be included
> > > before png.h. I will revert it tonight
> > 
> > I can't  apply the old patch, when i try do it i getting "No file to patch.
> > Skipping patch" i don't know why. But new patch works fine by me.
> 
> I don't understand what this means to be honest. The same patch applies to
> both ebuilds since the source code is the same. Anyway the old patch needs
> to be restored anyway

My bad,  patch works fine (checked by Pinkbyte). Please restore it.

[Comment 7 Markos Chandras (RETIRED) 2013-03-22 20:40:11 UTC]

Patch restored