Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46205 - Problems with commons-validator-1.0.2-r1 ebuild
Summary: Problems with commons-validator-1.0.2-r1 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-29 23:13 UTC by Eivind Tagseth
Modified: 2004-04-04 22:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eivind Tagseth 2004-03-29 23:13:27 UTC
Here's src_compile:

src_compile() {
        echo "oro.jar=`java-config --classpath=oro`" >> build.properties
        echo "commons-digester.jar=`java-config --classpath=commons-digester`" >> build.properties
        echo "commons-collections.jar=`java-config --classpath=commons-collections`" >> build.properties
        echo "commons-logging.jar=`java-config --classpath=commons-logging`" | sed s/.*:// >> build.properties
        echo "commons-beanutils.jar=`java-config --classpath=commons-beanutils`" >> build.properties
        echo "xerces.jar=`java-config --classpath=xerces`" >> build.properties

[usual make statements removed].

First, I think the above section should be part of src_unpack rather than compile.  That's how most other packages handles things, and the above lines would make build.properties duplicate it self for each invocation of ebuild commons-validator compile.

More seriously though, the commons-logging line above is wrong, the sed will remove more than it should, causing commons-logging to not be found.

Suggested replacement:

echo "commons-logging.jar=`java-config --classpath=commons-logging`" | sed 's/\(.*=\).*:/\1/' >> build.properties



Eivind
Comment 1 Chris Aniszczyk (RETIRED) gentoo-dev 2004-04-04 22:00:31 UTC
Fixed in portage now. I moved stuff to src_unpack and slightly modified the echo. Works fine.