Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461914 - dev-libs/libnfc-1.7.0 version bump
Summary: dev-libs/libnfc-1.7.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Auty (RETIRED)
URL: https://code.google.com/p/libnfc/sour...
Whiteboard:
Keywords:
Depends on:
Blocks: 452212
  Show dependency tree
 
Reported: 2013-03-16 10:18 UTC by Ulenrich
Modified: 2013-09-26 07:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulenrich 2013-03-16 10:18:14 UTC
see URL News file.

blocks:
https://bugs.gentoo.org/show_bug.cgi?id=452212
https://bugs.gentoo.org/show_bug.cgi?id=448860 glibc-2.17 tracker

Reproducible: Always
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2013-09-24 13:38:31 UTC
*libnfc-1.7.0 (24 Sep 2013)
24 Sep 2013; Manuel Rüger <mrueg@gentoo.org> +libnfc-1.7.0.ebuild:
NMU: Version bump. Fixes #461914.
Comment 2 Mike Auty (RETIRED) gentoo-dev 2013-09-25 22:44:59 UTC
Hi Manuel, thanks very much for bumping the package, I hadn't realized 1.7.0 had finally come out (this was requested months ago when the latest version was a release candidate, and I was intentionally not bumping it, but I only mentioned it on bug 353675 comment 2).

However, could you please check the ebuild?  Where ever you took that ebuild from, it doesn't use the correct driver list, and when compiled with USE="pcsc-lite", it fails with:

checking for debug flag... no
checking which drivers to build... arygon pn532_uart acr122 pn53x_usb
configure: error: Unknow driver: acr122

and the configure script's --help lists the following:

  --with-drivers=DRIVERS  Use a custom driver set, where DRIVERS is a
                          coma-separated list of drivers to build support for.
                          Available drivers are: 'acr122_pcsc', 'acr122_usb',
                          'acr122s', 'arygon', 'pn532_i2c', 'pn532_spi',
                          'pn532_uart' and 'pn53x_usb'. Default drivers set is
                          'acr122_usb,acr122s,arygon,pn532_i2c,pn532_spi,pn532_uart,pn53x_usb'.
                          The special driver set 'all' compile all available
                          drivers.

I'm not at home this week, and won't be able to fix this until the weekend, so could you please look into it and push a corrected ebuild as soon as possible?  Also, in future, if you're making changes to an ebuild without taking ownership of it, please mention it to the maintainer, and post the ebuild you're intending to use to the bug tracker for review before pushing it to the tree?
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2013-09-26 03:12:20 UTC
Hello Mike,

sorry I didn't look at the upstream release date of libnfc. 
I bumped it, because i needed a newer version for net-wireless/mfoc. 

The ebuild is mostly a reuse of the existing one, I just changed the version, but missed the new drivers. 
I revbumped the package now and everything should work now. 
Thanks for having a second look (also added an EAPI bump, dropping the PKG_CONFIG export that was fixed upstream, missed that too).

Usually I'm aware of the maintainer field in metadata.xml and try to reach them first. This time I needed the bump quickly and saw that this bug had no response for a long period of time. I better should have used my private overlay for this and talk to you first. So, sorry again.

Just a general question at the end for NMUs: Is it common to send an email to the maintainer (my original thought was that the maintainer receives already the bugmail)? After this I think it is actually a good idea, but should be documented somewhere.
Comment 4 Mike Auty (RETIRED) gentoo-dev 2013-09-26 07:53:24 UTC
Hiya,

Thanks for getting it fixed so quickly.  I understand the desire to bump to get something far newer in the tree, and I don't want to discourage the motivation or enthusiasm at all.  I appreciate someone else taking the interest, it's very easy on these small packages to feel like no one uses them, particularly without a flow of bugs (or even reminders about packages being bumped upstream).  5:)

I'm not sure what NMU means, but figuring the NM stands for non-maintainer, the only emails I got were when the bugs got closed.  I don't get emails when CVS is modified so the first I knew about it, it was already in the tree.  I do see the bugmail that's assigned to me as maintainer (so I had seen this bug, but I believe the older bump was still open at the time and shared my thoughts on the release candidates).  I should have corrected the title from libnfc-1.7.0 to libnfc-1.7.0_rc4 or whatever it was at the time, and I definitely needed to put a comment on this bug, and I'm sorry about that.  As such, I don't know whether NMUs should get an additional email, but probably some mention of what's going to happen on the bug before it actually does would be good...  5:)