Bug 461780 – net-misc/dahdi-2.6.2 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Oliver Jaksch 2013-03-15 06:28:18 UTC]

Created attachment 342070 [details]
new ebuild

Digium released dahdi-2.6.2 with some bugfixes.
I removed 08-less-polarity-reversals.diff and 09-double-underscore-dev.diff as they're already included by Digium now.
Compiles fine.

[Comment 1 Oliver Jaksch 2013-03-15 06:29:15 UTC]

Created attachment 342072 [details]
updated patchset

[Comment 2 Tony Vroon (RETIRED) 2013-03-18 09:40:50 UTC]

(In reply to comment #0)
> I removed 08-less-polarity-reversals.diff

I agree with this:
phoenix dahdi-linux-2.6.2 # patch -p1 -i /usr/src/dahdi-patchset/08-less-polarity-reversals.diff 
patching file drivers/dahdi/wctdm24xxp/base.c
Reversed (or previously applied) patch detected!  Assume -R? [n] ^C

> and 09-double-underscore-dev.diff

But not with this:
phoenix dahdi-linux-2.6.2 # patch -p1 -i /usr/src/dahdi-patchset/09-double-underscore-dev.diff 
patching file include/dahdi/kernel.h
Hunk #1 succeeded at 133 with fuzz 1 (offset 8 lines).

If you can convince me that 09 should not have applied I will redo the patchset as 1.1.5 as 1.1.4 had been uploaded before I read this bug in detail. My apologies.

[Comment 3 Oliver Jaksch 2013-03-18 10:02:13 UTC]

(In reply to comment #2)

> [...]
> If you can convince me that 09 should not have applied I will redo the
> patchset as 1.1.5 as 1.1.4 had been uploaded before I read this bug in
> detail. My apologies.

Yes, I *can* convince you :)  Have a look to the lines #123+ at the original source of dahdi-linux-2.6.2/include/dahdi/kernel.h - there's already this code.
The patch 09-double-underscore-dev.diff applys for sure but with the result that the code appears twice then. Unattractive IMHO...

[Comment 4 Tony Vroon (RETIRED) 2013-03-18 10:13:01 UTC]

+*dahdi-2.6.2 (18 Mar 2013)
+
+  18 Mar 2013; Tony Vroon <[e-mail]> +dahdi-2.6.2.ebuild:
+  Bugfix release; two of the downstream fixes have made it across. Patch
+  research & forward porting by Oliver Jaksch. Closes bug #461780.

Indeed, you have. Thanks Oliver :)

[Comment 5 Oliver Jaksch 2013-03-18 10:32:03 UTC]

(In reply to comment #4)
> +*dahdi-2.6.2 (18 Mar 2013)
> +
> +  18 Mar 2013; Tony Vroon <[e-mail]> +dahdi-2.6.2.ebuild:
> +  Bugfix release; two of the downstream fixes have made it across. Patch
> +  research & forward porting by Oliver Jaksch. Closes bug #461780.
> 
> Indeed, you have. Thanks Oliver :)

My pleasure! I'm doin' it again and yet again gladly :)