461658 – dev-python/spyder: Broken qt version detection with PyQt4-4.10

Bug 461658 - dev-python/spyder: Broken qt version detection with PyQt4-4.10

Summary: dev-python/spyder: Broken qt version detection with PyQt4-4.10

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Andrey Grozin

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-03-13 17:19 UTC by Reinis Danne
Modified:	2013-03-19 06:42 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
spyder-2.1.13-qt_requirements.patch (spyder-2.1.13-qt_requirements.patch,511 bytes, patch) 2013-03-13 17:20 UTC, Reinis Danne	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Reinis Danne 2013-03-13 17:19:09 UTC

Spyder uses string comparison for checking required PyQt4 version and it fails since "10" < "4+". It should do integer comparison.

Also, please, consider adding epatch_user to the ebuild.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 =PyQt4-4.10
2. emerge -1 spyder
3. spyder
Actual Results:  
Throws error asking to check installed PyQt4 version.

Expected Results:  
Should run fine since PyQt4-4.10 is newer than 4.4.

Comment 1 Reinis Danne 2013-03-13 17:20:03 UTC

Created attachment 341916 [details, diff]
spyder-2.1.13-qt_requirements.patch

Comment 2 Reinis Danne 2013-03-13 17:24:41 UTC

Just noticed that the docstring for check_version() says exactly opposite of what the code does (the check should be inverted), but that is upstream issue without direct user visibility.

Comment 3 Andrey Grozin gentoo-dev

2013-03-19 06:42:19 UTC

*spyder-2.1.13-r1 (19 Mar 2013)

  19 Mar 2013; Andrey Grozin <grozin@gentoo.org>
  -files/spyder-2.1.2-disable_sphinx_dependency.patch, -spyder-2.1.9.ebuild,
  -spyder-2.1.13.ebuild, +spyder-2.1.13-r1.ebuild,
  +files/spyder-2.1.13-qt_requirements.patch:
  Qt version detection fixed, closing #461658; thanks to Reinis Danne
  <rei4dan@gmail.com> for the patch.