Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46153 - cadubi-1.3.ebuild (New package)
Summary: cadubi-1.3.ebuild (New package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Mamoru KOMACHI (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2004-03-29 12:04 UTC by tklauser
Modified: 2004-05-07 03:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cadubi-1.3.ebuild (new package) (cadubi-1.3.ebuild,497 bytes, text/plain)
2004-03-29 12:05 UTC, tklauser
Details
Patch to change the path to the help.txt file (cadubi-1.3-helpfile.patch,347 bytes, patch)
2004-03-29 12:46 UTC, tklauser
Details | Diff
cadubi-1.3.ebuild (new package) changed as proposed (cadubi-1.3.ebuild,484 bytes, text/plain)
2004-03-29 12:47 UTC, tklauser
Details
cadubi-1.3.ebuild (new package) changed as proposed #2 (cadubi-1.3.ebuild,589 bytes, text/plain)
2004-03-29 13:10 UTC, tklauser
Details
cadubi-1.3.ebuild (new package) I'm just too stupid... (cadubi-1.3.ebuild,588 bytes, text/plain)
2004-03-29 13:22 UTC, tklauser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tklauser 2004-03-29 12:04:21 UTC
Hi there

I really like cadubi and installed it on my other (non-Gentoo) systems to create some fancy ASCII-Art stuff. Now I want this piece of software in my favourite distribution ;)
The development of cadubi has been stopped, so this is the last version of it.

For more information about cadubi go to: http://langworth.com/CadubiProject

You'll find my ebuild attached to this bug report. I've tested it on my local Gentoo box and it seems to work. I'd suggest to put it into app-misc (like figlet, a more or less similar program)

I'm looking forward to see my ebuild in the official Gentoo distribution.

Greetings from Switzerland

Tobias
Comment 1 tklauser 2004-03-29 12:05:17 UTC
Created attachment 28305 [details]
cadubi-1.3.ebuild (new package)
Comment 2 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-03-29 12:14:51 UTC
Hum, looks nice ;) I'll take it.
Comment 3 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-03-29 12:29:15 UTC
Thanks for introducing such a cute package. You ebuild looks fine but
the cadubi perl script needs "help.txt" to be in the same place as it
is installed (/usr/bin) in order to read the help.  However,
we don't want simple text file to be installed into /usr/bin, I
suggest to install it to /usr/lib/cadubi/help.txt and change cadubi
script accordingly (you may want to read the script and make a patch
to do that).

P.S.
"cd ${WORKDIR}/${P}" in src_install() isn't necessary as the initial
working directory of src_install() is automatically set to S 
(= ${WORKDIR}/${P}). See man 5 ebuild for more detail.
Comment 4 tklauser 2004-03-29 12:46:13 UTC
Created attachment 28308 [details, diff]
Patch to change the path to the help.txt file

I hope it's OK like that.
Comment 5 tklauser 2004-03-29 12:47:32 UTC
Created attachment 28309 [details]
cadubi-1.3.ebuild (new package) changed as proposed

I changed the ebuild as proposed. I hope it's OK like that.
Comment 6 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-03-29 13:02:19 UTC
You forgot to actually apply the patch ;) We usually do that
in src_unpack(). It may look like this:

src_unpack() {
	unpack ${A}
	cd ${S}
	epatch ${FILESDIR}/${P}-helpfile.patch
}

(where ${P} is expanded to "cadubi-1.3") Also, dolib installs help.txt
under /usr/lib (so it ends with /usr/lib/help.txt). You need to use
insinto/doins functions.

src_install() {
	...
	insinto /usr/lib/${PN}
	doins help.txt
	...
}

(again, ${PN} is expanded to "cadubi")

Hope this will help you writing the ebuild.
Comment 7 tklauser 2004-03-29 13:10:30 UTC
Created attachment 28310 [details]
cadubi-1.3.ebuild (new package) changed as proposed #2

It's late here in Switzerland ;) I hope the ebuild works now.

Thanks for your help usata
Comment 8 tklauser 2004-03-29 13:22:17 UTC
Created attachment 28313 [details]
cadubi-1.3.ebuild (new package) I'm just too stupid...

Two times src_install() ;)
Comment 9 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-03-29 13:32:15 UTC
Cool. I've just committed it to CVS. If you find any other package
useful/interesting/funny, feel free to create an ebuild and submit
it to bugzilla ;) Thanks for the contribution.
Comment 10 tklauser 2004-05-07 01:17:11 UTC
Do I need to mark this ebuild stable by myself and add it to bugzilla or does someone of the nice Gentoo guys do this?
Comment 11 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-05-07 03:10:44 UTC
Marked as stable. Thanks for the report. 

We usually wait for a month after introducing the ebuild to CVS.
If you find an ebuild which isn't marked stable for more than
several months (and you think the ebuild stable), please open 
a new bug for each ebuild that says "app-xxx/yyy-z.z.z.ebuild 
stable on x86" or something like that. diff to the modified ebuild
is preferred (If you just change KEYWORD, no attachment is needed).