Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461306 - repoman: spurious "unquoted variable" warnings
Summary: repoman: spurious "unquoted variable" warnings
Status: RESOLVED WORKSFORME
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-10 21:21 UTC by Ulrich Müller
Modified: 2013-03-10 22:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2013-03-10 21:21:59 UTC
With repoman from portage-2.1.11.55 I get spurious warnings about unquoted variables:

$ repoman

RepoMan scours the neighborhood...
  ebuild.minorsyn               3
   app-editors/emacs/emacs-23.4-r5.ebuild: Unquoted Variable on line: 286
   app-editors/emacs/emacs-24.3_rc2.ebuild: Unquoted Variable on line: 290
   app-editors/emacs/emacs-24.3_rc3.ebuild: Unquoted Variable on line: 290

Note: use --without-mask to check KEYWORDS on dependencies of masked packages
Note: use --include-dev (-d) to check dependencies for 'dev' profiles

RepoMan sez: "You're only giving me a partial QA payment?
              I'll take it this time, but I'm not happy."


In lines 289 to 291 of emacs-24.3_rc3.ebuild it can be seen that the variable really is within a quoted string:

    use aqua && DOC_CONTENTS+="\\n\\nEmacs${EMACS_SUFFIX#emacs}.app is in
        ${EPREFIX}/Applications/Gentoo. You may want to copy or symlink it
        into /Applications by yourself."
Comment 1 Zac Medico gentoo-dev 2013-03-10 22:13:35 UTC
The "unquoted variable" check really checks that ${EPREFIX} is quoted such that any whitespace it contains does not mix with surrounding whitespace. So, it triggers for your ${EPREFIX} reference because there are no quotes to separate ${EPREFIX} from surrounding whitespace. The following form should pass the check:


     use aqua && DOC_CONTENTS+="\\n\\nEmacs${EMACS_SUFFIX#emacs}.app is in
        '${EPREFIX}/Applications/Gentoo'. You may want to copy or symlink it
        into /Applications by yourself."