Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 460952 - =dev-java/jfreechart-1.0.14-r1 - Revision bump: Drop itext dependency or add examples USE flag, clarify servlet USE flag and possibly more (fix bugs that arise, ...)
Summary: =dev-java/jfreechart-1.0.14-r1 - Revision bump: Drop itext dependency or add ...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Java team
URL: http://www.jfree.org/jfreechart/
Whiteboard:
Keywords: EBUILD, PATCH
Depends on: 460950
Blocks: 474916
  Show dependency tree
 
Reported: 2013-03-09 13:54 UTC by Andreas Sturmlechner
Modified: 2014-11-16 22:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
jfreechart-1.0.14.diff against 1.0.13 (jfreechart-1.0.14.ebuild.diff,1.28 KB, patch)
2013-03-09 13:54 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14-build.xml.patch (jfreechart-1.0.14-build.xml.patch,1.31 KB, patch)
2013-03-09 13:55 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14.diff against 1.0.13 (v2) (jfreechart-1.0.14.ebuild.diff,1.13 KB, patch)
2013-03-10 12:59 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14.diff against 1.0.13 (v3) (jfreechart-1.0.14.ebuild_v3.diff,1.93 KB, patch)
2013-03-10 14:06 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14.diff against 1.0.13 (v3) (jfreechart-1.0.14.ebuild_v3.diff,1.85 KB, patch)
2013-03-10 14:16 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14-fix-TimeSeriesCollectionTests.patch (jfreechart-1.0.14-fix-TimeSeriesCollectionTests.patch,1.14 KB, patch)
2013-05-20 22:43 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14.diff against 1.0.13 (v4) (jfreechart-1.0.14.ebuild_v4.diff,2.01 KB, patch)
2013-05-20 22:46 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14-r1.ebuild.diff (jfreechart-1.0.14-r1.ebuild.diff,1.67 KB, patch)
2013-05-22 23:13 UTC, Andreas Sturmlechner
Details | Diff
jfreechart-1.0.14-r1.ebuild.diff (jfreechart-1.0.14-r1.ebuild.diff,1.65 KB, patch)
2013-05-22 23:23 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2013-03-09 13:54:34 UTC
Created attachment 341442 [details, diff]
jfreechart-1.0.14.diff against 1.0.13

Please bump, release was back in 21 Nov 2011.

Modified build.xml patch, small EAPI=4 cleanup.
Comment 1 Andreas Sturmlechner gentoo-dev 2013-03-09 13:55:53 UTC
Created attachment 341444 [details, diff]
jfreechart-1.0.14-build.xml.patch

required build.xml patch, smaller than the 1.0.13 patch.
Comment 2 Andreas Sturmlechner gentoo-dev 2013-03-09 13:57:26 UTC
Depends on >=dev-java/jcommon-1.0.17, also works with jcommon-1.0.18 which contains a bug fix.

Tested with icedtea-7.
Comment 3 Andreas Sturmlechner gentoo-dev 2013-03-10 12:59:41 UTC
Created attachment 341522 [details, diff]
jfreechart-1.0.14.diff against 1.0.13 (v2)

gained EAPI=4 knowledge from the jcommon bump request. :)
Comment 4 Andreas Sturmlechner gentoo-dev 2013-03-10 14:06:12 UTC
Created attachment 341532 [details, diff]
jfreechart-1.0.14.diff against 1.0.13 (v3)

some more modifications. less dependencies!

- introducing 'servlet' IUSE for I have no use for those few classes that require servlet-api:2.3
- itext-2.1.5 seems more appropriate a dependency (same as bundled version)
- junit-4 based on README.txt ("The JUnit tests included with JFreeChart have been created using JUnit 4.3.1.")

Tested successfully with icedtea-7.
Comment 5 Andreas Sturmlechner gentoo-dev 2013-03-10 14:16:54 UTC
Created attachment 341538 [details, diff]
jfreechart-1.0.14.diff against 1.0.13 (v3)

correcting that junit oops: not sure what's the correct test dependency, leaving it as-is.
Comment 6 Andreas Sturmlechner gentoo-dev 2013-05-20 21:57:45 UTC
Well, one test fails:

    [junit]     FAILED
    [junit] expected:<1.199142E12> but was:<1.1991456E12>
    [junit] junit.framework.AssertionFailedError: expected:<1.199142E12> but was:<1.1991456E12>
    [junit]     at org.jfree.data.time.junit.TimeSeriesCollectionTests.testFindDomainBounds(TimeSeriesCollectionTests.java:360)
    [junit]


which is... 1 hour? Not sure what to do there.
Comment 7 Andreas Sturmlechner gentoo-dev 2013-05-20 22:43:02 UTC
Created attachment 348798 [details, diff]
jfreechart-1.0.14-fix-TimeSeriesCollectionTests.patch

Patch for test failure
Comment 8 Andreas Sturmlechner gentoo-dev 2013-05-20 22:46:03 UTC
Created attachment 348800 [details, diff]
jfreechart-1.0.14.diff against 1.0.13 (v4)

ebuild update - now passes all tests successfully and builds, using icedtea-7.2.3.8
Comment 9 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-05-22 13:10:36 UTC
 <flag name='servlet'>Build a servlet using the servlet API.</flag>

I'm not using this package, did I get this USE flag description right?

 * Possibly unneeded dependencies found
 * 	itext

Any comment on this? Though it seems they still bring itext along so this feels like a false positive.

+  22 May 2013; Tom Wijsman <TomWij@gentoo.org>
+  +files/jfreechart-1.0.14-build.xml.patch,
+  +files/jfreechart-1.0.14-fix-TimeSeriesCollectionTests.patch,
+  +jfreechart-1.0.14.ebuild, metadata.xml:
+  Version bump to 1.0.14, contributed by Andreas Sturmlechner (genstorm). Fixes
+  bug #460952.
Comment 10 Andreas Sturmlechner gentoo-dev 2013-05-22 21:13:19 UTC
From the package.html inside the servlet directory:

"Classes for providing useful servlet and JSP functionality."


When I bumped the itext dependency I just edited what was there from 1.0.13, but in fact there is no reference in the source, only the Readme mentions "the demo application uses itext", which we don't install anyway. So, as long as we don't add an examples flag to install the demo binaries (no sources shipped), I guess we can drop the dep.
Comment 11 Andreas Sturmlechner gentoo-dev 2013-05-22 23:13:34 UTC
Created attachment 348950 [details, diff]
jfreechart-1.0.14-r1.ebuild.diff

I gave it a try:

This installs the demo to

/usr/share/jfreechart-1.0/lib/jfreechart-demo.jar

when USE="examples" is set.
Comment 12 Andreas Sturmlechner gentoo-dev 2013-05-22 23:23:47 UTC
Created attachment 348952 [details, diff]
jfreechart-1.0.14-r1.ebuild.diff

actually, make that better.

(test-built with icedtea-7)
Comment 13 Andreas Sturmlechner gentoo-dev 2014-11-16 22:07:40 UTC
Closing this one in favor of bug 528402 (1.0.19 version bump).