Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 460516 - distutils-r1.eclass modifies DOCDESTTREE
Summary: distutils-r1.eclass modifies DOCDESTTREE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 09:58 UTC by Ulrich Müller
Modified: 2013-03-09 13:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2013-03-06 09:58:39 UTC
Function distutils-r1_python_install_all assigns variable DOCDESTTREE directly.

It's not entirely clear what the status of the DOCDESTTREE variable is, see bug 460512. However, in either case it qualifies as a bug in the eclass:
- If it's a PMS-defined variable, then it must not be modified per PMS
  section 11.1: http://dev.gentoo.org/~ulm/pms/5/pms.html#x1-11800011.1
- If it's not defined (and in fact, the variable doesn't exist in Portage),
  then the assignment is futile.

Please change the eclass to use the docinto function instead.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-06 11:44:50 UTC
Wrt #1, does that mean that 'local INSDESTTREE' to avoid subshelling just to install one file is illegal as well?

Can we finally replace PMS with a spec that is at least self-consistent and have more defined behaviors than undefined ones?
Comment 2 Ulrich Müller gentoo-dev 2013-03-06 12:42:15 UTC
(In reply to comment #1)
> Wrt #1, does that mean that 'local INSDESTTREE' to avoid subshelling just to
> install one file is illegal as well?

"Ebuilds must not attempt to modify any of these variables, unless otherwise specified." Obviously, ebuilds can use insinto to modify INSDESTTREE, so I don't see a problem here.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-09 13:13:23 UTC
Switched to doins then.