Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 460346 - multibuild.eclass should have no EAPI check
Summary: multibuild.eclass should have no EAPI check
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 22:32 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2013-03-06 20:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2013-03-04 22:32:12 UTC
multibuild.eclass does not have any code requiring any particular EAPI, so the whole EAPI check should be deleted:

-case "${EAPI:-0}" in
-    0|1|2|3|4)
-        die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
-        ;;
-    5)
-        ;;
-    *)
-        die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
-        ;;
-esac
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-05 17:22:24 UTC
Sounds reasonable. Did you check it thoroughly? And what's the use case?
Comment 2 Arfrever Frehtes Taifersar Arahesis 2013-03-05 19:44:11 UTC
Eclass was fully checked.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-05 22:30:23 UTC
Please reopen if you have a use case for not using EAPI=5. Removing EAPI check completely isn't future-proof.
Comment 4 Arfrever Frehtes Taifersar Arahesis 2013-03-05 22:43:26 UTC
Example use case: A system package, which needs older EAPI to preserve upgrade path.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-06 06:19:07 UTC
I'm asking about real case, not theoretical one. And I exactly know what you're trying to do.

Also, we're requiring EAPI=5 for current profiles. The 'upgrade path' argument is no longer useful.
Comment 6 Arfrever Frehtes Taifersar Arahesis 2013-03-06 16:33:15 UTC
Another use case, definitely real: Ebuild, which uses a newer EAPI than EAPI="5". There are currently 2 such EAPIs.

EAPI of profile is unrelated to EAPI of ebuild.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-06 19:49:20 UTC
There are no officially approved EAPIs 'newer' than EAPI=5.
Comment 8 Arfrever Frehtes Taifersar Arahesis 2013-03-06 20:08:16 UTC
There is no reason to force any particular EAPI in an eclass, which works with all EAPIs. Eclasses like autotools.eclass or toolchain-funcs.eclass do not have such useless EAPI checks.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-06 20:40:45 UTC
(In reply to comment #8)
> There is no reason to force any particular EAPI in an eclass, which works
> with all EAPIs. Eclasses like autotools.eclass or toolchain-funcs.eclass do
> not have such useless EAPI checks.

How can I know that it works with them? A 'future' EAPI can be almost anything, and looking at the late events, they are actually a pile of random stuff.