Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 459688 - www-plugins/chrome-binary-plugins-9999: fails multilib-strict check and does not obey LDFLAGS
Summary: www-plugins/chrome-binary-plugins-9999: fails multilib-strict check and does ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords: Bug, PATCH, REVIEWED
: 454738 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-28 09:52 UTC by Richard Yao (RETIRED)
Modified: 2013-02-28 11:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
www-plugins/chrome-binary-plugins-9999 build.log (chrome-binary-plugins-9999:20130228-093952.log,10.44 KB, text/plain)
2013-02-28 09:52 UTC, Richard Yao (RETIRED)
Details
Patch to fix QA issues. (chrome-binary-plugins.patch,1.51 KB, patch)
2013-02-28 09:55 UTC, Richard Yao (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2013-02-28 09:52:27 UTC
Created attachment 340462 [details]
www-plugins/chrome-binary-plugins-9999 build.log

The ebuild should use $(get_libdir) from the multilib.eclass so that it does not trip multilib-strict. It also should set QA_FLAGS_IGNORED="/usr/$(get_libdir)/chromium-browser/*.so" to stop tripping the LDFLAGS check.
Comment 1 Richard Yao (RETIRED) gentoo-dev 2013-02-28 09:55:05 UTC
Created attachment 340464 [details, diff]
Patch to fix QA issues.

I have attached a patch from my local CVS that resolves the issues. I would commit it myself, but I tend to ask before making changes to packages that other people maintain. Just say the word and I will do the commit. Otherwise, feel free to commit this yourself.
Comment 2 Richard Yao (RETIRED) gentoo-dev 2013-02-28 09:56:26 UTC
I just noticed that my local checkout is somewhat out of date. The CVS header will likely prevent the patch from cleanly applying, but that is a minor issue.
Comment 3 Jason A. Donenfeld gentoo-dev 2013-02-28 11:20:18 UTC
That patch misses a few get_libdir places and doesn't account for all the .so files installed, but thanks for the pointers on how to do this right. The proper fix has now been committed to CVS.

+  28 Feb 2013; Jason A. Donenfeld <zx2c4@gentoo.org>
+  chrome-binary-plugins-9999.ebuild:
+  Use get_libdir for strict multilib, and do not complain about LDFLAGS.  This
+  fixes bug #459688
Comment 4 Jason A. Donenfeld gentoo-dev 2013-02-28 11:34:09 UTC
*** Bug 454738 has been marked as a duplicate of this bug. ***