Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 459178 - python-r1.eclass: Restore REQUIRED_USE check, make it optional
Summary: python-r1.eclass: Restore REQUIRED_USE check, make it optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 16:20 UTC by Mike Gilbert
Modified: 2013-05-21 01:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2013-02-25 16:20:52 UTC
We disabled this entirely for bug 447808, but I think it makes sense to re-enable it by default. We just need to provide a way for ebuilds to disable it in the eclass so they can handle it more precisely when python is an optional feature.
Comment 1 Mike Gilbert gentoo-dev 2013-02-25 18:48:20 UTC
I think a nice compromise would be to enable it by default in distutils-r1, with an option to disable it with the DISTUTILS_OPTIONAL variable.

We could then require ebuilds which use python-r1 directly to set REQUIRED_USE themselves, just as they do with PYTHON_DEPS in DEPEND.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-25 19:25:47 UTC
I see one major problem here. We need to find a non-confusing name. And considering that we use PYTHON_REQ_USE for something completely different doesn't help.
Comment 3 Mike Gilbert gentoo-dev 2013-02-25 20:02:29 UTC
Yes, that is unfortunate.

Perhaps we could deprecate the PYTHON_REQ_USE variable and rename it to something else.

Then, we could use a name like PYTHON_REQUIRED_USE for exporting metadata without causing too much long-term confusion.
Comment 4 Mike Gilbert gentoo-dev 2013-05-21 01:31:30 UTC
+  21 May 2013; Mike Gilbert <floppym@gentoo.org> distutils-r1.eclass,
+  python-r1.eclass, python-single-r1.eclass:
+  Set PYTHON_REQUIRED_USE, and add it to REQUIRED_USE in distutils-r1.