Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 45904 - rivatv-0.8.4.ebuild/distro missing patch file
Summary: rivatv-0.8.4.ebuild/distro missing patch file
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Television related Applications in Gentoo's Portage
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-27 09:25 UTC by Julie Brandon
Modified: 2004-07-11 04:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Brandon 2004-03-27 09:25:27 UTC
The ebuild/distro for rivatv-0.8.4 appears to be missing an associated patch file (rivatv-0.8.4-configure.patch) which prevents compilation.

Reproducible: Always
Steps to Reproduce:
1. ACCEPT_KEYWORDS="~x86" emerge rivatv

Actual Results:  
# ACCEPT_KEYWORDS="~x86" emerge rivatv
Calculating dependencies ...done!
>>> emerge (1 of 1) media-tv/rivatv-0.8.4 to /
>>> Downloading 
http://www.mirror.ac.uk/sites/www.ibiblio.org/gentoo/distfiles/rivatv-
0.8.4.tar.gz
--17:21:55--  
http://www.mirror.ac.uk/sites/www.ibiblio.org/gentoo/distfiles/rivatv-
0.8.4.tar.gz
           => `/usr/portage/distfiles/rivatv-0.8.4.tar.gz'
Resolving www.mirror.ac.uk... 194.83.57.15, 212.219.56.131, 212.219.56.146, ...
Connecting to www.mirror.ac.uk[194.83.57.15]:80... connected.
HTTP request sent, awaiting response... 404 Not Found
17:21:55 ERROR 404: Not Found.

>>> Downloading http://ftp.easynet.nl/mirror/gentoo/distfiles/rivatv-
0.8.4.tar.gz
--17:21:55--  http://ftp.easynet.nl/mirror/gentoo/distfiles/rivatv-0.8.4.tar.gz
           => `/usr/portage/distfiles/rivatv-0.8.4.tar.gz'
Resolving ftp.easynet.nl... 195.86.128.57
Connecting to ftp.easynet.nl[195.86.128.57]:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 177,977 [application/x-tar]

100%[==============================================>] 177,977       
56.12K/s    ETA 00:00

17:21:59 (55.88 KB/s) - `/usr/portage/distfiles/rivatv-0.8.4.tar.gz' saved 
[177977/177977]

>>> md5 src_uri ;-) rivatv-0.8.4.tar.gz
>>> Unpacking source...
>>> Unpacking rivatv-0.8.4.tar.gz to /var/tmp/portage/rivatv-0.8.4/work
RUNNING FROM extra_functions.sh

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 *
 *   /usr/portage/media-tv/rivatv/files/rivatv-0.8.4-configure.patch


!!! ERROR: media-tv/rivatv-0.8.4 failed.
!!! Function epatch, Line 220, Exitcode 0
!!! Cannot find $EPATCH_SOURCE!



Expected Results:  
Compiled!

Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9, 2.4.22-gentoo-
r7)
=================================================================
System uname: 2.4.22-gentoo-r7 i686 Intel(R) Pentium(R) 4 CPU 2.66GHz
Gentoo Base System version 1.4.3.13
Autoconf: sys-devel/autoconf-2.58-r1
Automake: sys-devel/automake-1.7.7
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=pentium4 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.
1/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/lib/mozil
la/defaults/pref /usr/share/config /usr/share/texmf/tex/generic/config/ /usr/sh
are/texmf/tex/platex/config/ /var/qmail/alias /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=pentium4 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://www.mirror.ac.uk/sites/www.ibiblio.org/gentoo/ 
http://ftp.easynet.nl/mirror/gentoo/ http://trumpetti.atm.tut.fi/gentoo/ 
http://ds.thn.htu.se/linux/gentoo "
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X Xaw3d acpi alsa apache2 apm arts avi berkdb cdr crypt cups dga directfb 
doc dvd dvdr encode esd fbcon foomaticdb gd gdbm gif gpm gtk gtk2 imap imlib 
innodb ipv6 jack java jpeg kde libg++ libwww mad maildir mbox mcal mikmod mmx 
motif mozilla mpeg mysql ncurses oggvorbis opengl oss pam pdflib perl png 
postgres ppds python qt quicktime readline ruby samba scanner sdl slang spell 
sse ssl svga tcpd tetex tiff truetype unicode usb videos wmf x86 xml xml2 xmms 
xv zlib"
Comment 1 Bart Lauwers (RETIRED) gentoo-dev 2004-04-06 18:23:04 UTC
Sorry about that inconvenience, I removed the code that tried to apply the non-existant patch, let me know how it goes please.
Comment 2 Julie Brandon 2004-04-06 23:56:39 UTC
How do.  Yep it _compiles_ fine here now, however there would appear to be another bug that causes rivatv.o module loading to fail on 2.4.22-gentoo-r7 at least.

/lib/modules/2.4.22-gentoo-r7/kernel/drivers/media/video/rivatv.o: /lib/modules/2.4.22-gentoo-r7/kernel/drivers/media/video/rivatv.o: unresolved symbol kernel_fpu_begin

This appears to be related to the code in rivatv-convert.c  

The code rivatv-convert.c suggests that 'kernel_fpu_begin' is not exported properly in pre 2.5 kernels, and so goes on to define this function itself instead... however it only does that *IF* RIVATV_DISABLE_CONVERSION is *NOT* defined.

However, *if* RIVATV_DISABLE_CONVERSION *IS* defined (as it is) then there are still parts of the code later on in rivatv-convert.c that attempt to use this otherwise undefined kernel_fpu_begin function (e.g. rivatv-convert.c line 741), and I dare say this why the module dependencies fail?

This looks like a possible bug in the rivatv code itself to me rather than in the ebuild or gentoo incompatibilies?

I'll probably give up with rivatv personally myself, however I'm happy to keep with these tests if you do want to get it working with 2.4.x
Comment 3 Patrice Bouvard 2004-04-07 16:54:39 UTC
it seems the patch are needed for 2.6.x kernel.. the ./arch/x86 was moved to ./arch/i386 and it seems the problem starts here

root@chocolat pabou # emerge rivatv
Calculating dependencies ...done!
>>> emerge (1 of 1) media-tv/rivatv-0.8.4 to /
>>> md5 src_uri ;-) rivatv-0.8.4.tar.gz
>>> Unpacking source...
>>> Unpacking rivatv-0.8.4.tar.gz to /var/tmp/portage/rivatv-0.8.4/work
>>> Source unpacked.
Checking for configured kernel headers... found [/lib/modules/2.6.4-ck1/build]
Checking for linux kernel >= 2.4.0... yes [2.6.4-ck1]
Using bttv sources in... bttv-2.6
Checking for kernel build system... found
Checking for kernel configuration... found
Checking for CONFIG_MODVERSIONS... no
Checking for CONFIG_PCI... yes [y]
Checking for CONFIG_VIDEO_DEV... yes [y]
Checking for CONFIG_PROC_FS... yes [y]
Checking for CONFIG_I2C... yes [y]
Checking for CONFIG_I2C_ALGOBIT... yes [y]
Checking for CONFIG_MODULES... yes [y]
Checking for kernel dependencies... not needed for 2.6.x kernels
Checking for RedHat or Mandrake kernel... no
Checking whether AGP code should be included... no
Checking whether software conversion code should be included... no
Creating Makefile... done
Checking your current setup for incompatibilities...
Checking for /proc... yes
Checking for kernel gcc... tail: `-1' option is obsolete; use `-n 1' since this will be removed in the future
3.3.3
Checking for framebuffer... no
Checking for SMP... no
 
No problems found.
To build RivaTV type `make'.  For cleaning up type `make clean`.
make -C /lib/modules/2.6.4-ck1/build SUBDIRS=`pwd`/bttv modules
make[1]: Entering directory `/usr/src/linux-2.6.4-ck1'
Makefile:406: /usr/src/linux-2.6.4-ck1/arch/x86/Makefile: No such file or directory
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
make[1]: *** No rule to make target `/usr/src/linux-2.6.4-ck1/arch/x86/Makefile'.  Stop.
make[1]: Leaving directory `/usr/src/linux-2.6.4-ck1'
make: [all-kbuild] Error 2 (ignored)
make -C /lib/modules/2.6.4-ck1/build SUBDIRS=`pwd`/src EXTRA_CFLAGS="-I`pwd`/bttv  -DRIVATV_DISABLE_AGP -DRIVATV_DISABLE_CONVERSION" modules
make[1]: Entering directory `/usr/src/linux-2.6.4-ck1'
Makefile:406: /usr/src/linux-2.6.4-ck1/arch/x86/Makefile: No such file or directory
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
make[1]: *** No rule to make target `/usr/src/linux-2.6.4-ck1/arch/x86/Makefile'.  Stop.
make[1]: Leaving directory `/usr/src/linux-2.6.4-ck1'
make: *** [all-kbuild] Error 2
 
!!! ERROR: media-tv/rivatv-0.8.4 failed.
!!! Function src_compile, Line 27, Exitcode 2
!!! (no error message)
Comment 4 Gabriel Devenyi 2004-06-17 18:48:09 UTC
The package, when extracted and compiled manually, builds fine, loads fine, with a simple ./configure and a make, make install. This is with 2.6.7-rc3-mm2. The compile fails with the error above when using the ebuild.
Comment 5 Bart Lauwers (RETIRED) gentoo-dev 2004-07-11 04:50:55 UTC
Please provide a patch to the ebuild to fix this, no testing hardware on this side.... help yourself I'd say.