pyzy was split by ibus upstream, start from ibus-pinyin-1.5.0. so bug #458678 depend on this Reproducible: Always
Created attachment 339660 [details] ebuild, workings here
Created attachment 339662 [details, diff] patches, for not download dictionary
Created attachment 339664 [details] metadata.xml file
I'd suggest also assign this to cjk team
Comment on attachment 339660 [details] ebuild, workings here >IUSE="+boost db doc +opencc" Original configure.ac default to use db, and default not to use boost and opencc. Is there some reason not to follow that default? Also I feel the USE flag name "db" is a bit confusing. The configure.ac's description is "build database from pinyin in android" and description for "--enable-db-open-phrase" is "build open-phrase database". I don't think it "enable support for database" >RDEPEND="dev-libs/glib:2 > !!<=app-i18n/ibus-pinyin-1.4.0 > boost? ( dev-libs/boost ) > opencc? ( app-i18n/opencc )" Some dependecies seems to be missing: dev-db/sqlite:3 and sys-apps/util-linux (for libuuid) >DEPEND="${DEPEND} > doc? ( app-doc/doxygen )" > >src_prepare() { > epatch "${FILESDIR}"/${PN}-dont-download-dictionary-file.patch > mv ../db ./data/db/open-phrase/ || die > eautoreconf >} python_convert_shebangs 2 "${S}"/data/db/android/create_db.py > >src_configure() { > econf \ > --enable-db-open-phrase \ > $(use_enable boost) \ > $(use_enable opencc) \ > $(use_enable db db-android) >} $(use_enable test tests) can be added.
Created attachment 340136 [details] updated ebuild (In reply to comment #5) > Comment on attachment 339660 [details] > ebuild, workings here > > >IUSE="+boost db doc +opencc" > > Original configure.ac default to use db, and default not to use boost and > opencc. Is there some reason not to follow that default? ok, I have no specific reason to use "boost opencc". but for open-phrase, I enable it by default, compare to db-android it has more accurate database. that's why I make USE="db" (for android db) disabled by default, but it's fine to enable it. I've tested with USE="-boost +db -doc -opencc -test", it works here. > > Also I feel the USE flag name "db" is a bit confusing. The configure.ac's > description is "build database from pinyin in android" and description for > "--enable-db-open-phrase" is "build open-phrase database". I don't think it > "enable support for database" > I'm also confusing .. and not sure what's the best desription to fit here feel free to adjust this .. > >RDEPEND="dev-libs/glib:2 > > !!<=app-i18n/ibus-pinyin-1.4.0 > > boost? ( dev-libs/boost ) > > opencc? ( app-i18n/opencc )" > > Some dependecies seems to be missing: dev-db/sqlite:3 and > sys-apps/util-linux (for libuuid) > Yes, good catch, my bad here. need to add to $DEPEND > >DEPEND="${DEPEND} > > doc? ( app-doc/doxygen )" > > > >src_prepare() { > > epatch "${FILESDIR}"/${PN}-dont-download-dictionary-file.patch > > mv ../db ./data/db/open-phrase/ || die > > eautoreconf > >} > > python_convert_shebangs 2 "${S}"/data/db/android/create_db.py > good, I've added this. > > > >src_configure() { > > econf \ > > --enable-db-open-phrase \ > > $(use_enable boost) \ > > $(use_enable opencc) \ > > $(use_enable db db-android) > >} > > $(use_enable test tests) can be added. yes, can do this
Comment on attachment 340136 [details] updated ebuild I've forgot some points left. >RDEPEND="dev-libs/glib:2 > dev-db/sqlite:3 > !!<=app-i18n/ibus-pinyin-1.4.0 > sys-apps/util-linux > boost? ( dev-libs/boost ) > opencc? ( app-i18n/opencc )" What's this ibus-pinyin blocker for? >DEPEND="${DEPEND} > doc? ( app-doc/doxygen )" DEPEND="${DEPEND} ..." is maybe typo? You still need RDEPEND stuffs at build time. >src_prepare() { > epatch "${FILESDIR}"/${PN}-dont-download-dictionary-file.patch To be precise, eautoreconf will updated the Makefile.in from the patched Makefile.am, so you don't need Makefile.in part
(In reply to comment #7) > Comment on attachment 340136 [details] > updated ebuild > > I've forgot some points left. > > >RDEPEND="dev-libs/glib:2 > > dev-db/sqlite:3 > > !!<=app-i18n/ibus-pinyin-1.4.0 > > sys-apps/util-linux > > boost? ( dev-libs/boost ) > > opencc? ( app-i18n/opencc )" > > What's this ibus-pinyin blocker for? Ok, I'm trying to avoid install both pyzy and <=ibus-pinyin-1.4.0 (due to file collision). we can think that version before 1.5.0 already include pyzy.. but, maybe I'm not doing right? or shouldn't I worry about this (since people will just install ibus-pinyin(1.5.0), and it will implicitly pull pyzy in)? but I still think people may have problem when they downgrade from 1.5.0 to 1.4.x (shouldn't this happen?) good secenario with: 1) <=ibus-pinyin-1.4.0 + no pyzy or 2) ibus-pinyin-1.5.0 + pyzy > > >DEPEND="${DEPEND} > > doc? ( app-doc/doxygen )" > > DEPEND="${DEPEND} ..." is maybe typo? You still need RDEPEND stuffs at build > time. > yeah, it's typo, should be DEPEND="${RDEPEND} > >src_prepare() { > > epatch "${FILESDIR}"/${PN}-dont-download-dictionary-file.patch > > To be precise, eautoreconf will updated the Makefile.in from the patched > Makefile.am, so you don't need Makefile.in part right, we can kill that part
(In reply to comment #8) > (In reply to comment #7) > > Comment on attachment 340136 [details] > > updated ebuild > > > > I've forgot some points left. > > > > >RDEPEND="dev-libs/glib:2 > > > dev-db/sqlite:3 > > > !!<=app-i18n/ibus-pinyin-1.4.0 > > > sys-apps/util-linux > > > boost? ( dev-libs/boost ) > > > opencc? ( app-i18n/opencc )" > > > > What's this ibus-pinyin blocker for? > > Ok, I'm trying to avoid install both pyzy and <=ibus-pinyin-1.4.0 (due to > file collision). we can think that version before 1.5.0 already include > pyzy.. > > but, maybe I'm not doing right? or shouldn't I worry about this (since > people will just install ibus-pinyin(1.5.0), and it will implicitly pull > pyzy in)? > but I still think people may have problem when they downgrade from 1.5.0 to > 1.4.x (shouldn't this happen?) > good secenario with: > 1) <=ibus-pinyin-1.4.0 + no pyzy > or > 2) ibus-pinyin-1.5.0 + pyzy Actually I don't think file collison is exist. I have following packages at the same time: % qlist -Iv ibus-pinyin app-i18n/ibus-pinyin-1.4.0 % qlist -Iv pyzy app-i18n/pyzy-0.1.0 This can be co-exist because package name is changed. Yes, they might be duplicate files, however I don't think it a serious problem. % qlist ibus-pinyin /usr/share/ibus-pinyin/db/android.db /usr/share/ibus-pinyin/db/open-phrase.db /usr/share/ibus-pinyin/db/create_index.sql ... % qlist pyzy /usr/share/pyzy/db/android.db /usr/share/pyzy/db/open-phrase.db /usr/share/pyzy/db/create_index.sql ...
I'm fine if you consider removing this "!!<=app-i18n/ibus-pinyin-1.4.0" seems useless.. then (In reply to comment #9)
Thank you for your ebuild. I've finally added your ebuild into the tree. BTW the metadata.xml has "<herd>proxy-maintainers</herd>". This means you are willing to be a maintainer for this package?
Hi, Naohiro Aota Yes, I've previously added a proxy maintainer tag there, but feel that pyzy is not a independent package (it's one of 'RDEPEND' dependency of ibus-pinyin). so, I'd keep it same as ibus-pinyin (make it under CJK herd) And I removed the tag at last step. I'm not sure whether you are actively maintain ibus related ebuilds, would be great if you can put me under proxy-maintainer list (of course, if you feel that you need any help here) I'm using ibus daily, and willing to help here.. (In reply to comment #11) > Thank you for your ebuild. I've finally added your ebuild into the tree. > > BTW the metadata.xml has "<herd>proxy-maintainers</herd>". This means you > are willing to be a maintainer for this package?
(In reply to comment #12) > Hi, Naohiro Aota > Yes, I've previously added a proxy maintainer tag there, but feel that pyzy > is not a independent package (it's one of 'RDEPEND' dependency of > ibus-pinyin). > so, I'd keep it same as ibus-pinyin (make it under CJK herd) > > And I removed the tag at last step. > I'm not sure whether you are actively maintain ibus related ebuilds, > would be great if you can put me under proxy-maintainer list (of course, if > you feel that you need any help here) > > I'm using ibus daily, and willing to help here.. > > (In reply to comment #11) > > Thank you for your ebuild. I've finally added your ebuild into the tree. > > > > BTW the metadata.xml has "<herd>proxy-maintainers</herd>". This means you > > are willing to be a maintainer for this package? Thanks, since I'm using ibus but not using ibus-pinyin usually, I'd appreciate your help :). I've just set up you for proxy-maintainership.
(In reply to comment #13) > Thanks, since I'm using ibus but not using ibus-pinyin usually, I'd > appreciate your help :). I've just set up you for proxy-maintainership. Hey, The pleasure always be mine ;-) and I'd really appreciate for pushing this.. (also, it would be great if you can put proxy-maintainters as second herd see: http://www.gossamer-threads.com/lists/gentoo/dev/269051) Since this is already resolved, so I think there is no block for bug #458678 (bump ibus-pinyin to 1.5.0), right? thanks
