Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 457920 - kde-base/kate-4.10.0-r1 improved ebuild
Summary: kde-base/kate-4.10.0-r1 improved ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-17 00:52 UTC by Alex Turbov
Modified: 2013-03-11 17:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kate w/ 'pate' replaced by 'python' and PYTHON_SINGLE_TARGET support (kate-4.10.0-r1.ebuild,1.12 KB, text/plain)
2013-02-17 00:53 UTC, Alex Turbov
Details
patch against kate-4.10.0.ebuild (kate-4.10.0-python-fixes.patch,1.07 KB, patch)
2013-02-18 04:22 UTC, Alex Turbov
Details | Diff
patch to fix errors in Python 3 for expand plugin (0001-fixes-for-runtime-errors-w-Python-3.patch,2.22 KB, patch)
2013-02-18 04:23 UTC, Alex Turbov
Details | Diff
kate-4.10.0-r2.ebuild w/ patch for Python 3 expand plugin (kate-4.10.0-r2.ebuild,1.21 KB, text/plain)
2013-02-18 04:23 UTC, Alex Turbov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2013-02-17 00:52:29 UTC
since KDE SC 4.10 kate has support for python plugins, but current ebuild nowadays restricted to Python 2 support only! Actually kate could be compiled (and work well) w/ Python 3 (thanx to Shaheed Haque, the main contributor to pate plugin in the last release).

In updated ebuild I've renamed `pate' to `python' USE flag (according "official" name of this plugin and just to reduce a count of less-known USE flags in sake of smth familiar). Also support for PYTHON_SINGLE_TARGET has been added: so kate ccan be compiled w/ Python 2.7 or 3.2.


Reproducible: Always
Comment 1 Alex Turbov 2013-02-17 00:53:48 UTC
Created attachment 339108 [details]
kate w/ 'pate' replaced by 'python' and PYTHON_SINGLE_TARGET support
Comment 2 Andreas Sturmlechner gentoo-dev 2013-02-17 10:32:10 UTC
Interesting. :)

Gentoo devs usually prefer unified diffs against an in-tree ebuild so that your changes can be more easily reviewed right here.
Comment 3 Alex Turbov 2013-02-18 04:22:19 UTC
Created attachment 339198 [details, diff]
patch against kate-4.10.0.ebuild

patch to rename 'pate' to 'python' USE, add support for Python 3 and fix a bug in expand pluing
Comment 4 Alex Turbov 2013-02-18 04:23:02 UTC
Created attachment 339200 [details, diff]
patch to fix errors in Python 3 for expand plugin
Comment 5 Alex Turbov 2013-02-18 04:23:56 UTC
Created attachment 339202 [details]
kate-4.10.0-r2.ebuild w/ patch for Python 3 expand plugin
Comment 6 Alex Turbov 2013-02-18 04:25:35 UTC
(In reply to comment #2)
> Interesting. :)
> 
> Gentoo devs usually prefer unified diffs against an in-tree ebuild so that
> your changes can be more easily reviewed right here.

added a diff and updated r2 of the ebuild (w/ fixes for Python 3 in the 'expand' plugin taken from kate.git master branch)
Comment 7 Michael Palimaka (kensington) gentoo-dev 2013-02-26 07:49:53 UTC
Nice!

I see you committed your patch directly upstream, how about backporting to KDE/4.10 too?
Comment 8 Alex Turbov 2013-02-26 08:36:19 UTC
(In reply to comment #7)
> Nice!
> 
> I see you committed your patch directly upstream, how about backporting to
> KDE/4.10 too?

Done
Comment 9 Michael Palimaka (kensington) gentoo-dev 2013-03-01 16:49:16 UTC
Thanks, pushed to the overlay.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=2982529d6c6141e3ebdba3bfb490fcc3fc93df38