Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 45784 - bootsplash updates for rc-scripts
Summary: bootsplash updates for rc-scripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 58516 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-26 02:18 UTC by Michal Januszewski (RETIRED)
Modified: 2004-08-18 13:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the patch for rc-scripts (rc-scripts-1.4.3.13p1-bootsplash.patch,2.44 KB, patch)
2004-03-26 02:18 UTC, Michal Januszewski (RETIRED)
Details | Diff
a new rc-scripts patch (rc-scripts-1.4.3.13p1-bootsplash-r2.patch,3.56 KB, patch)
2004-03-26 04:14 UTC, Michal Januszewski (RETIRED)
Details | Diff
The new patch for rc-scripts. (rc-sripts-splash.patch,11.34 KB, patch)
2004-08-06 03:55 UTC, Michal Januszewski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Januszewski (RETIRED) gentoo-dev 2004-03-26 02:18:08 UTC
Since in bootsplash-0.6-r12 /etc/conf.d/bootsplash.conf has been renamed to /etc/conf.d/bootsplash (to fit the standard /etc/conf.d/ naming scheme), all references to bootsplash.conf in functions.sh should be updated. I've also noticed that the silent Bootsplash doesn't work on system reboot/shutdown with recent versions of rc-scripts. I'm attaching a patch against the latest released version of rc-scripts to fix both functions.sh and the silent splash problems.
Comment 1 Michal Januszewski (RETIRED) gentoo-dev 2004-03-26 02:18:49 UTC
Created attachment 28046 [details, diff]
the patch for rc-scripts
Comment 2 Michal Januszewski (RETIRED) gentoo-dev 2004-03-26 04:14:25 UTC
Created attachment 28052 [details, diff]
a new rc-scripts patch

I've just made a few more changes to the rc-scripts. I added the done_start and
done_step bootsplash events. These new events will be used for boot animations,
which will be introduced in the next bootsplash release. The done* events are
the ones which update the progress bar status, the old start and stop events
are only used to signal bootsplash to start animations. Please note that this
will break old bootsplash releases, so plz let me know before new base-layout
is relased so that I could commit the new bootsplash ebuild to CVS.
Comment 3 Aron Griffis (RETIRED) gentoo-dev 2004-08-01 16:00:51 UTC
Thanks Spock, I applied the first half of this patch (or a version thereof).  For the remainder, could you please do the following:

1. supply a patch that fixes the current problems that I can apply immediately.  I'm not familiar enough with the bootsplash stuff to be able to differentiate.  Please make the patch against current cvs gentoo-src/rc-scripts/sbin/functions.sh

2. Figure out a way to make the upgrade path seamless.  You say that "this
will break old bootsplash releases" but that isn't acceptable unless it's absolutely required.  Instead you should include some logic so that both old and new versions will work.  Since the done_* stuff is all handled by splash_update, you might consider putting the compatibility logic there so that the rest of the code is clean.
Comment 4 solar (RETIRED) gentoo-dev 2004-08-01 16:52:40 UTC
How would we feel about moving bootsplash out of the /sbin/functions.sh and it's it's own support file that gets sourced in by functions.sh if it exists?
Comment 5 Aron Griffis (RETIRED) gentoo-dev 2004-08-01 17:12:04 UTC
Sounds delicious to me
Comment 6 Aron Griffis (RETIRED) gentoo-dev 2004-08-01 17:15:57 UTC
*** Bug 58516 has been marked as a duplicate of this bug. ***
Comment 7 Michal Januszewski (RETIRED) gentoo-dev 2004-08-02 17:52:10 UTC
Ok, I'm on it (it = moving as much of the bootsplash stuff as possible out of functions.sh + updated patches for rc-scripts). I'll try to make it compatible with all current versions of bootsplash and prepare it for gensplash/splashutils.
Comment 8 Carter 2004-08-02 21:53:05 UTC
See http://www.aichler.net/gentoo/bootsplash/ whic was contained in the Bug in Comment #6.  Also read the following post:
http://forums.gentoo.org/viewtopic.php?t=144497&highlight=animation+cfg
Note the answer by c0bblers.  It would be nice to get the animations working as im sure the Gentoo user community could come up w/ some cool animations.
Comment 9 Michal Januszewski (RETIRED) gentoo-dev 2004-08-06 03:55:53 UTC
Created attachment 36879 [details, diff]
The new patch for rc-scripts.

The attached patch moved all *splash-support functions to a separate file
called splash-functions.sh. All communication is done via the 'splash'
function. The splash clients can respond to the events as they see fit (some
events may be ignored). The latest release of bootsplash -r5 is compatible with
both the current rc-scripts and the patched rc-scripts. splashutils/gensplash
will be compatible with the new one only.

This new way of doing things will break old bootsplash versions, but:
1) it's inevitable
2) when new rc-scripts are released, they will be marked unstable. Users using
'unstable' systems will get both the latest bootsplash and the latest
rc-scripts , so they won't notice any problems. By the time the patched
baselayout is made stable, bootsplash-0.6.1-r5 will be stable, too, so
everything will work for 'stable' users, too.
Comment 10 Aron Griffis (RETIRED) gentoo-dev 2004-08-18 13:44:14 UTC
ok, it's in baselayout-1.10.4.  Thanks for your patience, and sorry for the wait.