Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 455898 - app-admin/webmin - new ebuild and new ebuild revisions
Summary: app-admin/webmin - new ebuild and new ebuild revisions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL: http://www.webmin.com/changes.html
Whiteboard:
Keywords: EBUILD, InVCS, PATCH
Depends on:
Blocks:
 
Reported: 2013-02-06 19:58 UTC by PhobosK
Modified: 2013-02-06 20:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
webmin-1.620.ebuild (webmin-1.620.ebuild.diff,1.05 KB, patch)
2013-02-06 19:58 UTC, PhobosK
Details | Diff
gentoo-setup (gentoo-setup.diff,1.76 KB, patch)
2013-02-06 20:00 UTC, PhobosK
Details | Diff
webmin-1.600-r2.ebuild (webmin-1.600-r2.ebuild.diff,682 bytes, patch)
2013-02-06 20:02 UTC, PhobosK
Details | Diff
webmin-1.610-r1.ebuild (webmin-1.610-r1.ebuild.diff,676 bytes, patch)
2013-02-06 20:04 UTC, PhobosK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PhobosK 2013-02-06 19:58:56 UTC
Created attachment 338134 [details, diff]
webmin-1.620.ebuild

There is a new upstream version of Webmin - 1.620 with a lot of bugfixes and important security updates one of which is:
"Fixed an XSS attack in miniserv error messages, and added an option to disable SSL compression to defeat the BEAST attack."

So here are the 1.620 ebuild changes:
1. In order to tighten the security of Webmin on Gentoo I had forcibly disabled SSL compression for new installs and for already existing ones that doesn't have any "no_sslcompression" option state. 
2. Since this new option ("no_sslcompression") in /etc/miniserv.conf is not recognized at all in the old Webmin versions and they do not have any problem with it, I have put that forcibly in the "gentoo-setup" script, so it is changed too.
3. The addition of the install mode/type in the "install-type" file which is needed when an upgrade of Webmin is done from within the application. We should have in mind that the upgrade process from within Webmin is still buggy in Gentoo, but I am working with the upstream author to fix this issue.

Since the above changes are needed in the older ebuilds (that are in the portage tree) too, I am uploading new revisions of them also, so I do not open separate bugs for all of them. Actually you may delete all old revisions of Webmin in portage since as you know every minor upstream release is actually a bugfix release, and since we have in portage 1.600 and 1.610 the latest 1.620 fixes any previous bugs.

Thanks.
Comment 1 PhobosK 2013-02-06 20:00:49 UTC
Created attachment 338136 [details, diff]
gentoo-setup

Minor edits in the setup script so BEAST attacks are mitigated
Comment 2 PhobosK 2013-02-06 20:02:43 UTC
Created attachment 338138 [details, diff]
webmin-1.600-r2.ebuild

The webmin-1.600-r2.ebuild with a small install-type fix. This is if you decide to keep the Webmin 1.600 in portage
Comment 3 PhobosK 2013-02-06 20:04:02 UTC
Created attachment 338140 [details, diff]
webmin-1.610-r1.ebuild

A minor fix for the install-type. This is if you decide to keep the Webmin 1.610 in portage.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2013-02-06 20:04:49 UTC
You confused me a little bit. You said that

"2. Since this new option ("no_sslcompression") in /etc/miniserv.conf is not recognized at all in the old Webmin versions and they do not have any problem with it, I have put that forcibly in the "gentoo-setup" script, so it is changed too."

and then

"Since the above changes are needed in the older ebuilds (that are in the portage tree) too, I am uploading new revisions of them also, so I do not open separate bugs for all of them."

I am fine with deleting all the webmin ebuilds but 1.620 by the way.
Comment 5 PhobosK 2013-02-06 20:07:58 UTC
Well sorry my fault for the misconfusion... 
Actually only change 3 is needed in the older ebuilds. I just wanted to say that 1 and 2 do not mess up with the older versions, so the gentoo-setup script changes are totally сафе :)
Comment 6 PhobosK 2013-02-06 20:10:33 UTC
Sorry for the last word in Cyrillic... Bad keyboard ;)
 
=== Cyrillic fix ===
Well sorry my fault for the confusion... 
Actually only change 3 is needed in the older ebuilds. I just wanted to say that 1 and 2 do not mess up with the older versions, so the gentoo-setup script changes are totally safe for the old ebuilds/versions of the app :)
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2013-02-06 20:14:12 UTC
+*webmin-1.620 (06 Feb 2013)
+
+  06 Feb 2013; Markos Chandras <hwoarang@gentoo.org> +webmin-1.620.ebuild,
+  -files/webmin-1.600-SA51201.patch, -webmin-1.600-r1.ebuild,
+  -webmin-1.610.ebuild, files/gentoo-setup:
+  Version bump. Drop old ebuilds. Bug #455898. Thanks to PhobosK
+  <phobosk@fastmail.fm>
+