Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 455358 - Add ZFS feature flag support to sys-boot/grub:2
Summary: Add ZFS feature flag support to sys-boot/grub:2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: Highest enhancement (vote)
Assignee: Mike Gilbert
URL: https://github.com/maxximino/grub2
Whiteboard:
Keywords: Goal, Inclusion
Depends on:
Blocks:
 
Reported: 2013-02-03 22:10 UTC by Richard Yao (RETIRED)
Modified: 2013-02-03 22:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Feature flag support patch for sys-boot/grub:2 (grub-2.00-zfs-feature-flag-support.patch,29.55 KB, patch)
2013-02-03 22:10 UTC, Richard Yao (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2013-02-03 22:10:18 UTC
Created attachment 337862 [details, diff]
Feature flag support patch for sys-boot/grub:2

The latest version of ZFSOnLinux adds support for feature flags, which is incompatible with sys-boot/grub:2. There are warnings about compatibility in the ZFS ebuilds. However, one user has already reported to me that he has a non-bootable system, so I consider adding feature flags to be a high priority.

I started a port of feature flag support from Illumos to GRUB2, but maxximino from #zfsonlinux on freenode informed me that he has already done the work. His work was against GRUB2 HEAD, but it applies perfectly to our current GRUB2 package. I have attached a monolithic patch containing his work, plus a tiny fix so that the result builds properly.

I have tested this on my own system and I can confirm that it works properly. As per an agreement with floppym in IRC, I am committing sys-boot/grub-2.00-r2 masked for his inspection. I am opening this bug to serve as a reference in the ebuild.