Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 455054 - sys-fs/btrfs-progs: add symlink /sbin/fsck.btrfs -> /sbin/btrfsck
Summary: sys-fs/btrfs-progs: add symlink /sbin/fsck.btrfs -> /sbin/btrfsck
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
: 478704 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-01 21:26 UTC by marius.spix
Modified: 2013-07-30 01:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description marius.spix 2013-02-01 21:26:43 UTC
There should be a symlink /sbin/fsck.btrfs -> /sbin/btrfsck

It is not automatically created. I manually ran 
"ln -s /sbin/btrfsck /sbin/fsck.btrfs"

This would make running /sbin/fsck in scripts easier because this tool detects the file system in the /etc/fstab and than executes /sbin/fsck.$(FILE_SYSTEM)
Comment 1 Mike Gilbert gentoo-dev 2013-02-04 03:00:32 UTC
The btrfs wiki basically says not to do this. They recommend making fsck.btrfs a symlink to /bin/true.

https://btrfs.wiki.kernel.org/index.php/FAQ#When_will_Btrfs_have_a_fsck_like_tool.3F
Comment 2 marius.spix 2013-02-11 14:23:08 UTC
Ok,than i propose to link it to /bin/true. But what if /bin/true is a link to /bin/busybox ? This would only cause trouble ...
Comment 3 Mike Gilbert gentoo-dev 2013-02-11 15:29:15 UTC
I thought it over, and I'm just going to leave it as-is. fstab should be configured to not run fsck for btrfs filesystems; putting in the /bin/true symlink would only mask this from the sysadmin.

slyfox: If you disagree, feel free to implement whatever solution you think is best here.
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2013-02-11 19:10:33 UTC
(In reply to comment #3)
> I thought it over, and I'm just going to leave it as-is. fstab should be
> configured to not run fsck for btrfs filesystems; putting in the /bin/true
> symlink would only mask this from the sysadmin.
> 
> slyfox: If you disagree, feel free to implement whatever solution you think
> is best here.

I agree. btrfs is not mature enough to claim it has an fsck.
Explicit fail is a good thing.

I think btrfs' wiki suggests a symlink because some tools
just refuse to boot when fsck is missing.
Comment 5 Mike Gilbert gentoo-dev 2013-07-30 01:28:10 UTC
*** Bug 478704 has been marked as a duplicate of this bug. ***