Bug 454172 – RFC: strip_eprefix and prepend_eprefix helpers

• Status: RESOLVED WONTFIX
• Product: Portage Development

[Description Benda Xu 2013-01-26 15:29:27 UTC]

In the patch two helper functions strip_eprefix and prepend_eprefix which strips and prepends ${EPREFIX} from/to path.

Corresponding ins*/dodoc are updated to use these 2 new helpers.

Reproducible: Always

[Comment 1 Benda Xu 2013-01-26 15:29:52 UTC]

Created attachment 336916 [details, diff]
eprefix_path_helper.patch

[Comment 2 Fabian Groffen 2013-01-26 15:31:05 UTC]

really, isn't this what bash is very good at?

[Comment 3 Benda Xu 2013-01-26 15:35:27 UTC]

(In reply to comment #2)
> really, isn't this what bash is very good at?

It also has "if it does not contain $EPREFIX in path, prepend" function. Therefore hopefully it will reduce double prefix bug in the future.

[Comment 4 Fabian Groffen 2013-01-26 15:37:10 UTC]

That's just swiping a bug under the carpet, IMO.  People should not use EPREFIX with helpers.

[Comment 5 Benda Xu 2013-01-26 15:42:22 UTC]

Hmm.. but how to deal with situations like bug 452890, where insinto and python_get_incdir confuses people by whether or not it should provide a $EPREFIX in the path?

[Comment 6 Fabian Groffen 2013-01-26 15:48:11 UTC]

The previous Python maintainer felt that calls like python_get_incdir should not include EPREFIX, and the current one feels it should IIRC, so that's a human problem, IMO.

[Comment 7 Benda Xu 2014-02-01 10:53:37 UTC]

close as wontfix then, thanks Fabian.