454134 – sci-biology/samtools-0.1.80-r1: missing pkgconfig dependency, strange sed

Bug 454134 - sci-biology/samtools-0.1.80-r1: missing pkgconfig dependency, strange sed

Summary: sci-biology/samtools-0.1.80-r1: missing pkgconfig dependency, strange sed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Justin Lecher (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-01-26 11:33 UTC by Torsten Veller (RETIRED)
Modified:	2013-01-27 18:09 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch (samtools-0.1.18-r1.ebuild.patch,851 bytes, patch) 2013-01-26 11:33 UTC, Torsten Veller (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Torsten Veller (RETIRED) gentoo-dev

2013-01-26 11:33:36 UTC

Created attachment 336880 [details, diff]
Patch

+DEPEND="virtual/pkgconfig"
+
 src_prepare() {
        sed \
-               -e '/CC/s:=:?=:g' \
-               -e "/LIBCURSES/s:=.*$:= $(pkg-config --libs ncurses):g" \
-               -e '/^CFLAGS=/d' \
+               -e '/^CC=/s:=:?=:' \
+               -e "/^LIBCURSES=/s:=.*:= $(pkg-config --libs ncurses):" \
+               -e '/^CFLAGS=/s:=:?=:' \


- Uses pkg-config, but does not depend on it
- '/CC/s:=:?=:g' replaces
| - $(MAKE) CC="$(CC)" DFLAGS="$(DFLAGS)" CFLAGS="$(CFLAGS)" \
| + $(MAKE) CC?="$(CC)" DFLAGS?="$(DFLAGS)" CFLAGS?="$(CFLAGS)" \
while i guess you only wanted to update the assignment.
- global switch not needed

Thanks

Comment 1 Torsten Veller (RETIRED) gentoo-dev

2013-01-26 12:09:13 UTC

(In reply to comment #0)
> -               -e "/LIBCURSES/s:=.*$:= $(pkg-config --libs ncurses):g" \
> +               -e "/^LIBCURSES=/s:=.*:= $(pkg-config --libs ncurses):" \

> - Uses pkg-config, but does not depend on it

And sys-libs/ncurses too.

Comment 2 Justin Lecher (RETIRED) gentoo-dev

2013-01-26 18:58:25 UTC

(In reply to comment #0)
> Created attachment 336880 [details, diff] [details, diff]
> Patch
> 
> +DEPEND="virtual/pkgconfig"
> +
>  src_prepare() {
>         sed \
> -               -e '/CC/s:=:?=:g' \
> -               -e "/LIBCURSES/s:=.*$:= $(pkg-config --libs ncurses):g" \
> -               -e '/^CFLAGS=/d' \
> +               -e '/^CC=/s:=:?=:' \
> +               -e "/^LIBCURSES=/s:=.*:= $(pkg-config --libs ncurses):" \
> +               -e '/^CFLAGS=/s:=:?=:' \
> 
> 
> - Uses pkg-config, but does not depend on it
> - '/CC/s:=:?=:g' replaces
> | - $(MAKE) CC="$(CC)" DFLAGS="$(DFLAGS)" CFLAGS="$(CFLAGS)" \
> | + $(MAKE) CC?="$(CC)" DFLAGS?="$(DFLAGS)" CFLAGS?="$(CFLAGS)" \

good catch. I will fix that.

Comment 3 Justin Lecher (RETIRED) gentoo-dev

2013-01-27 18:09:53 UTC

+*samtools-0.1.18-r2 (27 Jan 2013)
+
+  27 Jan 2013; Justin Lecher <jlec@gentoo.org> -samtools-0.1.18-r1.ebuild,
+  +samtools-0.1.18-r2.ebuild:
+  Add missing deps and correct sed lines, #454134; thanks Torsten Veller
+