Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 454068 - sci-electronics/gtkwave-3.3.42: fails to build
Summary: sci-electronics/gtkwave-3.3.42: fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: The Soldering-Iron Brotherhood
URL: https://tinderboxlogs.s3.amazonaws.co...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 22:55 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2013-01-26 20:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2013-01-25 22:55:28 UTC
Portage 2.2.0_alpha149 (default/linux/amd64/10.0, gcc-4.7.2-asneeded, glibc-2.17, 3.5.4-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.5.4-hardened-r1-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.2
Timestamp of tree: Sun, 30 Dec 2012 00:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p39-r1
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.7.2
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo tbamd64
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LANG="en_US.utf8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY="/root/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx doc dri emacs ffmpeg fortran gnutls gpm iconv icu intl introspection ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma pppd qt3support readline semantic-desktop session snmp sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd udev unicode vhosts zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Thomas Beierlein gentoo-dev 2013-01-26 15:23:45 UTC
Seems similar to the problem reported for gtk-3.2.3 (see bug #248811) some time ago.

In a run of 10..20 tries it compiles mostly clean here but failes around 2..5 times. There seems to be no relation to any USE flag combination.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2013-01-26 15:28:37 UTC
It seems to be a parallel make problem, as the file is compiled befor eantlr finished generating it, but I don't see the rule that is compiling it in the output (not sure if antlr would do that by itself).

Do you want to try looking into this yourself (I can give you a few pointers from my blog) or would you rather me looking into it?
Comment 3 Thomas Beierlein gentoo-dev 2013-01-26 16:27:25 UTC
(In reply to comment #2)
> It seems to be a parallel make problem, as the file is compiled befor eantlr
> finished generating it, but I don't see the rule that is compiling it in the
> output (not sure if antlr would do that by itself).
> 
> Do you want to try looking into this yourself (I can give you a few pointers
> from my blog) or would you rather me looking into it?

Just saw that my bug reference was totally wrong. The correct one was bug #338940.

And I am not quite sure if it is a parallel make problem. The file in quesiton (verilog.g) is already provided in the package and after a succesfull make it is not changed in any way. It also is an *input* file to eantlr.

I fear it is a problem in eantlr itself. I will try to look into it.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2013-01-26 16:37:20 UTC
Sorry I misread the log.

The problem is that from verilog.g we generate verilog.c, verilog.c in turn uses #line to declare that it's coming from a different file. This means that the errors we see happening in verilog.g are actually in verilog.c.

If we see this snippet:

../pccts/antlr/antlr -ga -k 2 -gl ./verilog.g
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..   -DWAVE_USE_GTK2  -I. -I./../pccts/h -I../.. -O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches  -DFST_WRITER_PARALLEL -c symbol.c
Antlr parser generator   Version 1.33MR33   1989-2001
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..   -DWAVE_USE_GTK2  -I. -I./../pccts/h -I../.. -O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches  -DFST_WRITER_PARALLEL -c verilog.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..   -DWAVE_USE_GTK2  -I. -I./../pccts/h -I../.. -O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches  -DFST_WRITER_PARALLEL -c shred.c
./verilog.g, line 1771: warning: alts 1 and 2 of (..) ambiguous upon { V_ELSE }, { V_LBRACE V_AT V_SEMI ... }

we have the antlr command listed, then symbol.c starts comiling, then the antlr banner, then verilog.c starts compiling, then shred.c starts compiling and then we have an antlr status message.

This means that before antlr finished generating verilog.c, gcc alredy started compiling -> race condition.
Comment 5 Thomas Beierlein gentoo-dev 2013-01-26 16:53:26 UTC
(In reply to comment #4)
> Sorry I misread the log.
> 
> The problem is that from verilog.g we generate verilog.c, verilog.c in turn
> uses #line to declare that it's coming from a different file. This means
> that the errors we see happening in verilog.g are actually in verilog.c.
> 
...
> 
> This means that before antlr finished generating verilog.c, gcc alredy
> started compiling -> race condition.

You are right. I just found it myself during the tests. Seems I missread your log file.

Just found some comment in gtkwaves bugbase about a parallel make issue in just our directory some month ago. I will dig further.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2013-01-26 17:04:51 UTC
Okay I checked the Makefile.am and here's what I found:

verilog.c parser.dlg tokens.h err.c : $(srcdir)/verilog.g
        $(ANTLR) $(AFLAGS) $(srcdir)/verilog.g

this rule is wrong, see http://goo.gl/PYRMk

BUILT_SOURCES= definehash.c keywordhash.c tokens.h

this lacks the list above (verilog.c, tokens.h, err.c), so automake will not pre-build the sources before compiling.
Comment 7 Thomas Beierlein gentoo-dev 2013-01-26 20:02:15 UTC
(In reply to comment #6)
> Okay I checked the Makefile.am and here's what I found:
> 
> verilog.c parser.dlg tokens.h err.c : $(srcdir)/verilog.g
>         $(ANTLR) $(AFLAGS) $(srcdir)/verilog.g
> 
> this rule is wrong, see http://goo.gl/PYRMk
> 
> BUILT_SOURCES= definehash.c keywordhash.c tokens.h
> 
> this lacks the list above (verilog.c, tokens.h, err.c), so automake will not
> pre-build the sources before compiling.

Got that working. Patched Makefile.am and called eautoreconf. 
Build fine as long as USE=tcl is not set. After eautoreconf it does not recognize tcl and tk any more. So more to do ....
Comment 8 Thomas Beierlein gentoo-dev 2013-01-26 20:30:44 UTC
(In reply to comment #7)
> Got that working. Patched Makefile.am and called eautoreconf. 
> Build fine as long as USE=tcl is not set. After eautoreconf it does not
> recognize tcl and tk any more. So more to do ....

Got it. AT_M4DIR to the rescue.

Fixed. Thanks for help Diego.

+  26 Jan 2013; Thomas Beierlein <tomjbe@gentoo.org> gtkwave-3.3.42.ebuild,
+  +files/gtkwave-parallel-make.diff:
+  Fix parallel build (bug 454068). Thanks Diego. Respect system AR