Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 453324 - media-tv/kodi bundled stuff to unbundle
Summary: media-tv/kodi bundled stuff to unbundle
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 12:28 UTC by Tomáš Chvátal (RETIRED)
Modified: 2017-06-06 15:03 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
projectm.patch (projectm.patch,2.57 KB, patch)
2013-01-26 12:07 UTC, Tomáš Chvátal (RETIRED)
Details | Diff
projectm.patch (0001-Allow-usage-of-system-ProjectM.patch,3.86 KB, patch)
2013-02-23 11:42 UTC, Tomáš Chvátal (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-21 12:28:50 UTC
Hi,

I am opening this bug so I won't forget about fixing at least few of the bundling issues xbmc has. The goal is that I will write patch for upstream to include so we don't polute our sweet ebuild.

Bundled libs:
/usr/lib64/xbmc/system/ImageLib-x86_64-linux.so
/usr/lib64/xbmc/system/libexif-x86_64-linux.so

Not sure if it is handler on bundled lib yet:
/usr/lib64/xbmc/system/players/paplayer/libsidplay2-x86_64-linux.so
/usr/lib64/xbmc/system/players/paplayer/timidity-x86_64-linux.so


Pysqlite (python[sqlite]) and simplejson:
/usr/share/xbmc/addons/script.module.pysqlite
/usr/share/xbmc/addons/script.module.pysqlite/addon.xml
/usr/share/xbmc/addons/script.module.pysqlite/lib
/usr/share/xbmc/addons/script.module.pysqlite/lib/pysqlite2
/usr/share/xbmc/addons/script.module.pysqlite/lib/pysqlite2/__init__.py
/usr/share/xbmc/addons/script.module.simplejson
/usr/share/xbmc/addons/script.module.simplejson/addon.xml
/usr/share/xbmc/addons/script.module.simplejson/lib
/usr/share/xbmc/addons/script.module.simplejson/lib/LICENSE.txt
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson/__init__.py
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson/decoder.py
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson/encoder.py
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson/scanner.py
/usr/share/xbmc/addons/script.module.simplejson/lib/simplejson/tool.py

Fonts (should rather use fontconfig to get them):
/usr/share/xbmc/media/Fonts/arial.ttf
/usr/share/xbmc/media/Fonts/teletext.ttf
/usr/share/xbmc/addons/skin.confluence/fonts/DejaVuSans-Bold-Caps.ttf
/usr/share/xbmc/addons/skin.confluence/fonts/NOTICE.txt
/usr/share/xbmc/addons/skin.confluence/fonts/README.txt
/usr/share/xbmc/addons/skin.confluence/fonts/Roboto-Bold.ttf
/usr/share/xbmc/addons/skin.confluence/fonts/Roboto-Regular.ttf

(easiest for now maybe just do symlink in the ebuild)

Bundled fontconfig stuff:
/usr/share/xbmc/system/players/dvdplayer/etc/fonts/conf.avail
/usr/share/xbmc/system/players/dvdplayer/etc/fonts/conf.d
/usr/share/xbmc/system/players/dvdplayer/etc/fonts/fonts.conf
/usr/share/xbmc/system/players/dvdplayer/etc/fonts/fonts.dtd

(easiest for now maybe just do symlink in the ebuild)
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-21 21:00:39 UTC
Pysqlite seems to be only proper hook so it is not bundled.
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-21 21:08:33 UTC
Simplejson code deleted from live ebuild as all python scripts use system one already anyway.
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-26 11:05:03 UTC
Fontconfig configs are used only on Mac.
It can't be eqasily patched upstream as they install with find over all files they have in one folder. The rm added to install phase.
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-26 11:18:55 UTC
As the font install is done same way as other files we can't patch the build system.

I added symlinks for the required fonts apart from the unknown ones.

The unknown ones are:
{Dejavu/Roboto}-Bold-Caps.ttf (which seems made by them for menuitems).
teletext.ttf (the git does not point out the source of the file anywhere :/)
Comment 5 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-26 12:07:37 UTC
Created attachment 336886 [details, diff]
projectm.patch

V1 of projectm unbundling patch. Still need to make the presets dir configurable, other than that it should be fine.
Comment 6 BT 2013-01-27 23:57:23 UTC
(In reply to comment #4)
> I added symlinks for the required fonts apart from the unknown ones.

I now get the following QA messages when emerging XBMC:

* QA Notice: dosym target omits basename: '/usr/share/xbmc/media/Fonts/'
* QA Notice: dosym target omits basename: '/usr/share/xbmc/addons/skin.confluence/fonts/'
* QA Notice: dosym target omits basename: '/usr/share/xbmc/addons/skin.confluence/fonts/'
Comment 7 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-28 08:28:51 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > I added symlinks for the required fonts apart from the unknown ones.
> 
> I now get the following QA messages when emerging XBMC:
> 
> * QA Notice: dosym target omits basename: '/usr/share/xbmc/media/Fonts/'
> * QA Notice: dosym target omits basename:
> '/usr/share/xbmc/addons/skin.confluence/fonts/'
> * QA Notice: dosym target omits basename:
> '/usr/share/xbmc/addons/skin.confluence/fonts/'

Will look to it in a bit, thanks for headsup.
Comment 8 Tomáš Chvátal (RETIRED) gentoo-dev 2013-01-29 17:12:26 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > I added symlinks for the required fonts apart from the unknown ones.
> 
> I now get the following QA messages when emerging XBMC:
> 
> * QA Notice: dosym target omits basename: '/usr/share/xbmc/media/Fonts/'
> * QA Notice: dosym target omits basename:
> '/usr/share/xbmc/addons/skin.confluence/fonts/'
> * QA Notice: dosym target omits basename:
> '/usr/share/xbmc/addons/skin.confluence/fonts/'

And fixed :-)
Comment 9 SpanKY gentoo-dev 2013-02-18 19:39:54 UTC
Comment on attachment 336886 [details, diff]
projectm.patch

i don't mind adding patches like this to the ebuild
Comment 10 Tomáš Chvátal (RETIRED) gentoo-dev 2013-02-23 11:42:27 UTC
Created attachment 339786 [details, diff]
projectm.patch

Updated patch for the projectm that hopefully does everything right.

It is based against 12.0 as live version needs bit adjusted patch (fuzz in the patchdata, code is same).

I will submit it to upstream to pick and merge.
Comment 11 Tomáš Chvátal (RETIRED) gentoo-dev 2013-02-23 11:46:45 UTC
Upstream issue: https://github.com/xbmc/xbmc/issues/2290
Comment 12 Tomáš Chvátal (RETIRED) gentoo-dev 2013-03-31 15:08:47 UTC
(In reply to comment #11)
> Upstream issue: https://github.com/xbmc/xbmc/issues/2290

As upstream desires pull requests updated the request with:

https://github.com/xbmc/xbmc/pull/2519
Comment 13 Tomáš Chvátal (RETIRED) gentoo-dev 2013-04-20 16:50:01 UTC
Will add the projectm patch to 9999 and 12.1-r1 ebuilds in few hours.

From further checking I find that it also bundles libdvdnav and libdvdcss.
Comment 14 Craig Andrews gentoo-dev 2017-06-06 15:03:07 UTC
As far as I know, all external libraries mentioned in this bug and that I've been tracking (for years) have finally been externalized upstream (as of Kodi 17).

Therefore, I'm closing this issue - if there are any libraries that are still bundled that I haven't noticed / am not aware of / that are added in future versions of Kodi, please don't hesitate to open new bugs.