Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 453206 - multilib.eclass: please set PKG_CONFIG_PATH in multilib_toolchain_setup()
Summary: multilib.eclass: please set PKG_CONFIG_PATH in multilib_toolchain_setup()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-20 18:19 UTC by Michał Górny
Modified: 2013-01-21 19:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch adding exports (0001-Export-proper-PKG_CONFIG_-LIBDIR-PATH-for-multilib-b.patch,1.63 KB, text/plain)
2013-01-20 18:31 UTC, Michał Górny
Details
Fixed style (0001-Export-proper-PKG_CONFIG_-LIBDIR-PATH-for-multilib-b.patch,1.62 KB, patch)
2013-01-21 08:34 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-20 18:19:32 UTC
I'm using the multilib_toolchain_setup to get everything set up for a multilib build. It would be great if that function handled pkg-config as well.

I'm not sure if we should mangle PKG_CONFIG_PATH or just export a plain one. I will attach a patch once I get it to work somehow ;).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-20 18:31:38 UTC
Created attachment 336232 [details]
Patch adding exports

I'm exporting two vars there:

1) PKG_CONFIG_LIBDIR=/usr/$(get_libdir)/pkgconfig
2) PKG_CONFIG_PATH=/usr/share/pkgconfig

it may seem a bit ugly but we need to override PKG_CONFIG_LIBDIR so that in case of missing .pc file, pkg-config won't look in the default one (lib64). And since the fallback is always performed, I see no point in duplicating the path in PKG_CONFIG_PATH.
Comment 2 SpanKY gentoo-dev 2013-01-21 07:18:51 UTC
Comment on attachment 336232 [details]
Patch adding exports

>-		for v in CHOST CBUILD AS CC CXX LD ; do
>+		for v in CHOST CBUILD AS CC CXX LD PKG_CONFIG_LIBDIR PKG_CONFIG_PATH
>+		do

don't screw with the style (break it)

you can condense the vars into PKG_CONFIG_{PATH,LIBDIR}

the rest looks OK
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-21 08:29:49 UTC
(In reply to comment #2)
> Comment on attachment 336232 [details]
> Patch adding exports
> 
> >-		for v in CHOST CBUILD AS CC CXX LD ; do
> >+		for v in CHOST CBUILD AS CC CXX LD PKG_CONFIG_LIBDIR PKG_CONFIG_PATH
> >+		do
> 
> don't screw with the style (break it)

It was to keep the line-width.

> you can condense the vars into PKG_CONFIG_{PATH,LIBDIR}

Ok.

> the rest looks OK
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-21 08:34:28 UTC
Created attachment 336318 [details, diff]
Fixed style

Here you go.
Comment 5 SpanKY gentoo-dev 2013-01-21 18:29:43 UTC
Comment on attachment 336318 [details, diff]
Fixed style

looks fine ... feel free to commit
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-21 19:22:38 UTC
/var/cvsroot/gentoo-x86/eclass/ChangeLog,v  <--  ChangeLog
new revision: 1.630; previous revision: 1.629
/var/cvsroot/gentoo-x86/eclass/multilib.eclass,v  <--  multilib.eclass
new revision: 1.102; previous revision: 1.101