Bug 453058 – About where to locate EAPI/PMS meaning information

• Status: RESOLVED FIXED
• Product: Documentation

[Description Pacho Ramos 2013-01-19 22:59:54 UTC]

I found it's a bit difficult to find what EAPI and PMS are in devmanual, I needed to finally go to:
http://wiki.gentoo.org/wiki/PMS
http://wiki.gentoo.org/wiki/EAPI

to find its descriptions :/

Maybe they should be included to:
http://devmanual.gentoo.org/ebuild-writing/eapi/index.html

at the top as an introduction

Reproducible: Always

[Comment 1 Markos Chandras (RETIRED) 2013-01-19 23:45:36 UTC]

Patch ? :)

[Comment 2 Pacho Ramos 2013-01-20 07:26:39 UTC]

Created attachment 336188 [details, diff]
0001-Provide-proper-descriptions-for-PMS-and-EAPI-concept.patch

[Comment 3 Ulrich Müller 2013-01-20 09:51:48 UTC]

(In reply to comment #2)
> Created attachment 336188 [details, diff] [details, diff]
> 0001-Provide-proper-descriptions-for-PMS-and-EAPI-concept.patch

"Community-driven"? Most things in Gentoo are community-driven, so why should it be mentioned here? One could even argue that it applies much less to PMS whose versions must be approved by the council. I'd suggest to strike these two words out, as they carry no information.

[Comment 4 Pacho Ramos 2013-01-20 11:02:14 UTC]

Created attachment 336196 [details, diff]
0001-Provide-proper-descriptions-for-PMS-and-EAPI-concept.patch

I agree

[Comment 5 Markos Chandras (RETIRED) 2013-01-20 15:00:55 UTC]

The patch looks good to me. I'd say feel free to commit it.

[Comment 6 Pacho Ramos 2013-01-20 15:11:45 UTC]

(In reply to comment #5)
> The patch looks good to me. I'd say feel free to commit it.

Do you have some place explaining me how to commit? (I haven't ever committed anything using git :S)

[Comment 7 Markos Chandras (RETIRED) 2013-01-20 18:14:55 UTC]

(In reply to comment #6)
> (In reply to comment #5)
> > The patch looks good to me. I'd say feel free to commit it.
> 
> Do you have some place explaining me how to commit? (I haven't ever
> committed anything using git :S)

Well you managed to create a git formatted patch. Committing is just a matter of doing "git push" (better do git pull --rebase first to make sure you are up2date)

[Comment 8 Pacho Ramos 2013-01-20 22:36:02 UTC]

I got:
$ git pull --rebase
remote: Counting objects: 9, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 5 (delta 3), reused 0 (delta 0)
Unpacking objects: 100% (5/5), done.
From git+ssh://git.overlays.gentoo.org/proj/devmanual
   2ad86e6..31eaa24  master     -> origin/master
First, rewinding head to replay your work on top of it...
Applying: Update place to put big patches, bug #453064
Applying: Provide proper descriptions for PMS and EAPI concepts, bug #453058

And saw that also the other patch was committed, right?

[Comment 9 Markos Chandras (RETIRED) 2013-01-21 09:12:51 UTC]

Yes you committed both patches because both of them were in your local tree. You might want to have a look in "git rebase -i" (aka interactive rebase) in the future ;)

[Comment 10 Ulrich Müller 2013-01-21 10:33:31 UTC]

Also you've committed not this patch:

(In reply to comment #4)
> Created attachment 336196 [details, diff]
> 0001-Provide-proper-descriptions-for-PMS-and-EAPI-concept.patch
> 
> I agree

... but an earlier version.

[Comment 11 Pacho Ramos 2013-01-21 17:27:36 UTC]

Just fixed