Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 452890 - dev-python/imaging-1.1.7-r2.ebuild fails install (prefix) - QA concerns: double prefix files installed
Summary: dev-python/imaging-1.1.7-r2.ebuild fails install (prefix) - QA concerns: doub...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-19 01:36 UTC by Steven Trogdon
Modified: 2013-01-26 15:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,100.10 KB, text/plain)
2013-01-19 01:36 UTC, Steven Trogdon
Details
build-python2.7 log (build-python2.7.log,96.27 KB, text/plain)
2013-01-19 01:37 UTC, Steven Trogdon
Details
eprefix_path_helper.patch (eprefix_path_helper.patch,2.50 KB, patch)
2013-01-26 12:35 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Trogdon 2013-01-19 01:36:32 UTC
Created attachment 336082 [details]
build log

On ~amd64-linux imaging-1.1.7-r2 fails with:

running install_scripts
creating /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image/_python2.7/storage/strogdon/gentoo/usr/bin
copying /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/work/Imaging-1.1.7-python2_7/scripts/pilfile.py -> /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin
copying /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/work/Imaging-1.1.7-python2_7/scripts/pilfont.py -> /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin
copying /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/work/Imaging-1.1.7-python2_7/scripts/pilprint.py -> /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin
copying /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/work/Imaging-1.1.7-python2_7/scripts/pilconvert.py -> /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin
copying /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/work/Imaging-1.1.7-python2_7/scripts/pildriver.py -> /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin
changing mode of /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin/pilfile.py to 755
changing mode of /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin/pilfont.py to 755
changing mode of /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin/pilprint.py to 755
changing mode of /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin/pilconvert.py to 755
changing mode of /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/bin/pildriver.py to 755
running install_egg_info
Writing /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/lib/python2.7/site-packages/PIL/PIL-1.1.7-py2.7.egg-info
creating /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image//_python2.7/storage/strogdon/gentoo/usr/lib/python2.7/site-packages/PIL.pth
 ^[[32;01m*^[[0m common: running python_install_all
>>> Completed installing imaging-1.1.7-r2 into /storage/strogdon/gentoo/var/tmp/portage/dev-python/imaging-1.1.7-r2/image/

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line
   usr/lib/python2.7/site-packages/PIL/_imagingmath.so
   usr/lib/python2.7/site-packages/PIL/_imagingft.so
   usr/lib/python2.7/site-packages/PIL/_imaging.so
ecompressdir: bzip2 -9 /usr/share/doc
 ^[[33;01m*^[[0m QA Notice: storage/strogdon/gentoo///storage/strogdon/gentoo/ double prefix
 ^[[33;01m*^[[0m QA Notice: storage/strogdon/gentoo///storage/strogdon/gentoo/usr double prefix
 ^[[33;01m*^[[0m QA Notice: storage/strogdon/gentoo///storage/strogdon/gentoo/usr/include double prefix
 ^[[33;01m*^[[0m QA Notice: storage/strogdon/gentoo///storage/strogdon/gentoo/usr/include/python2.7 double prefix
 ^[[31;01m*^[[0m ERROR: dev-python/imaging-1.1.7-r2 failed:
 ^[[31;01m*^[[0m   Aborting due to QA concerns: double prefix files installed
---

emerge --info '=dev-python/imaging-1.1.7-r2'

Portage 2.2.01.21580-prefix (prefix/linux/amd64, gcc-4.6.3, unavailable, 2.6.32-5-amd64 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.32-5-amd64-x86_64-Six-Core_AMD_Opteron-tm-_Processor_2427-with-debian-6.0.6
Timestamp of tree: Thu, 17 Jan 2013 15:38:43 +0000
ld GNU ld (GNU Binutils) 2.23
ccache version 3.1.8 [enabled]
app-shells/bash:          4.2_p39-r1::gentoo_prefix
dev-java/java-config:     2.1.11-r3::gentoo_prefix
dev-lang/python:          2.7.3-r2::gentoo_prefix, 3.3.0::gentoo_prefix
dev-util/ccache:          3.1.8::gentoo_prefix
dev-util/cmake:           2.8.10.2-r1::gentoo_prefix
dev-util/pkgconfig:       0.27.1::gentoo_prefix
sys-devel/autoconf:       2.13::gentoo_prefix, 2.69::gentoo_prefix
sys-devel/automake:       1.11.6::gentoo_prefix, 1.12.4::gentoo_prefix
sys-devel/binutils:       2.23::gentoo_prefix
sys-devel/gcc:            4.4.6-r1::gentoo_prefix, 4.5.4::gentoo_prefix, 4.6.3::gentoo_prefix
sys-devel/gcc-config:     1.8-r00.1::gentoo_prefix
sys-devel/libtool:        2.4.2::gentoo_prefix
sys-devel/make:           3.82-r4::gentoo_prefix
sys-kernel/linux-headers: 3.7::gentoo_prefix (virtual/os-headers)
Repositories: gentoo_prefix local-overlay sage-on-gentoo sage-on-prefix my-gentoo-sage
ACCEPT_KEYWORDS="~amd64-linux"
ACCEPT_LICENSE="* -@EULA dlj-1.1 Oracle-BCLA-JavaSE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=opteron -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-march=opteron -O2 -pipe"
DISTDIR="/storage/strogdon/gentoo/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=n"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-lo
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j13"
PKGDIR="/storage/strogdon/gentoo/usr/portage/packages"
PORTAGE_CONFIGROOT="/storage/strogdon/gentoo/"
PORTAGE_RSYNC_EXTRA_OPTS="--delete-after --timeout=500"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/storage/strogdon/gentoo/var/tmp"
PORTDIR="/storage/strogdon/gentoo/usr/portage"
PORTDIR_OVERLAY="/storage/strogdon/gentoo/usr/local/portage /storage/strogdon/gentoo/usr/local/portage/sage-on-gentoo /storage/strogdon/gentoo/usr/local/portage/sage-on-prefix /storage/strogdon/gentoo/usr/local/portage/my-gentoo-sage"
SYNC="rsync://rsync.prefix.freens.org/gentoo-portage-prefix"
USE="amd64 berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx modules mudflap ncurses nls nptl openmp pcre pppd prefix readline session sse sse2 ssl tcpd unicode zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON
---

emerge -pqv '=dev-python/imaging-1.1.7-r2'

[ebuild     U ] dev-python/imaging-1.1.7-r2 [1.1.7-r1] USE="-X -doc -examples -lcms -scanner -tk" PYTHON_TARGETS="python2_7%* -python2_5% -python2_6%"
---

Note: the double prefixed folders are simply extraneously created folders.
Comment 1 Steven Trogdon 2013-01-19 01:37:27 UTC
Created attachment 336084 [details]
build-python2.7 log
Comment 2 Steven Trogdon 2013-01-20 02:54:23 UTC
With the new distutils-r1/python-utils-r1 eclasses $(python_get_includedir) includes ${EPREFIX} and this seems to be the source of the failure when installing with

python_install() {
        insinto "$(python_get_includedir)"
        doins libImaging/{Imaging.h,ImPlatform.h}

        wrap_phase distutils-r1_python_install
}

in prefix. If this is not a bug then here the following, perhaps not very elegant, changes allowed imaging-1.1.7-r2 to build:

@@ -76,7 +76,9 @@
 }
 
 python_install() {
-       insinto "$(python_get_includedir)"
+       python_export PYTHON_INCLUDEDIR
+       PYTHON_INSDIR="${PYTHON_INCLUDEDIR#${EPREFIX}}"
+       insinto "${PYTHON_INSDIR}"
        doins libImaging/{Imaging.h,ImPlatform.h}
 
        wrap_phase distutils-r1_python_install
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2013-01-24 20:18:55 UTC
I think the new python eclass shouldn't prepend EPREFIX to the getter.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-24 21:16:45 UTC
(In reply to comment #3)
> I think the new python eclass shouldn't prepend EPREFIX to the getter.

I think 'insinto' shouldn't prepend EPREFIX to the path. But it's not me who created this inconsistency with every other thing.
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2013-01-24 21:57:02 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I think the new python eclass shouldn't prepend EPREFIX to the getter.
> 
> I think 'insinto' shouldn't prepend EPREFIX to the path. But it's not me who
> created this inconsistency with every other thing.
And I think, insinto should handle both cases.
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2013-01-25 08:16:59 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > I think the new python eclass shouldn't prepend EPREFIX to the getter.
> > 
> > I think 'insinto' shouldn't prepend EPREFIX to the path. But it's not me who
> > created this inconsistency with every other thing.
> And I think, insinto should handle both cases.

Zac, what is your comment here?
Comment 7 Zac Medico gentoo-dev 2013-01-25 15:55:02 UTC
It seems reasonable to handle both cases. It could be ambiguous if ${EPREFIX} is not a sufficiently unique path, but that case seems negligible.
Comment 8 Benda Xu gentoo-dev 2013-01-26 01:00:06 UTC
Or adding helper scripts of eprefix/deprefix to prepend/strip eprefix to standardize the writing of "${EPREFIX}"/usr and ${A_PATH_WITH_EPREFIX#"${EPREFIX}"} alike.

Any dir can be passed into the helper pair while the result is consistent.

So the phrase in python-r1 would be 

insinto "$(deprefix $(python_get_includedir))"

Or just hide d/eprefix inside "insinto".
Comment 9 Benda Xu gentoo-dev 2013-01-26 12:35:22 UTC
Created attachment 336888 [details, diff]
eprefix_path_helper.patch

@Zac, how about this patch?
Comment 10 Zac Medico gentoo-dev 2013-01-26 14:19:20 UTC
(In reply to comment #9)
> Created attachment 336888 [details, diff] [details, diff]
> eprefix_path_helper.patch
> 
> @Zac, how about this patch?

You can only return integers in bash, so you need to echo "$1" instead of return it. Make sure you quote the echo argument, in order to preserve whitespace (otherwise bash uses $IFS to re-interpreted the whitespace).

Is your plan to introduce this change in EAPI 6? If so, then all of the new behavior needs to be conditional on EAPI.
Comment 11 Benda Xu gentoo-dev 2013-01-26 15:24:34 UTC
Oh Michał Górny has kindly fixed the bug :) close as resolved and insinto updates will be in tracked separately.