Bug 452404 – games-rpg/xu4 patch to adjust to macro changes in zlib

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Matthew Gillespie 2013-01-15 20:27:29 UTC]

The games-rpg/xu4 package appears to not compile due to macro name changes cited in bug#383179.

Reproducible: Always

Steps to Reproduce:
1. Attempt to emerge games-rpg/xu4 on system with >sys-libs/zlib-1.2.5.1
Actual Results:  
>>> Compiling source in /var/tmp/portage/games-rpg/xu4-0.9/work/u4 ...
make -C src DEBUGCFLAGS= 'E_CFLAGS=-O2 -march=i686 -pipe' bindir=/usr/games/bin datadir=/usr/share libdir=/
usr/games/lib 
make: Entering directory `/var/tmp/portage/games-rpg/xu4-0.9/work/u4/src'
i686-pc-linux-gnu-gcc -DHAVE_BACKTRACE=1 -DHAVE_VARIADIC_MACROS=1 -O2 -march=i686 -pipe -I. -I/usr/include/
SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/libxml2 -DICON_FILE=\"/usr/share/pixmaps/u4.bmp\" -DVERSION
=\"0.9\"    -c -o annotation.o annotation.c
In file included from u4file.h:9:0,
                 from map.h:17,
                 from location.h:8,
                 from context.h:8,
                 from annotation.c:10:
unzip.h:114:45: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:127:32: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:138:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:145:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:153:40: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:166:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:172:36: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:179:34: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:192:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:218:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:224:40: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:231:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:245:32: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:250:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
unzip.h:255:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OF'
make: *** [annotation.o] Error 1
make: Leaving directory `/var/tmp/portage/games-rpg/xu4-0.9/work/u4/src'
emake failed


Expected Results:  
The package should have compiled correctly.

Attached is a simple patch to accommodate the macro name changes.

[Comment 1 Matthew Gillespie 2013-01-15 20:28:49 UTC]

Created attachment 335744 [details, diff]
unzip.h, unzip.c macro updates.

[Comment 2 Mr. Bones. (RETIRED) 2013-01-15 22:44:00 UTC]

in portage.  thanks for the bug report and patch.