Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 451578 - app-text/evince-3.6.1 Add dbus use flag for machines without dbus running
Summary: app-text/evince-3.6.1 Add dbus use flag for machines without dbus running
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-01-12 21:44 UTC by Brennan Shacklett
Modified: 2013-07-27 11:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info,3.76 KB, text/plain)
2013-01-12 21:44 UTC, Brennan Shacklett
Details
Adds a dbus use flag (default on) to the ebuild (evince-3.6.1.ebuild-dbus-use.patch,894 bytes, patch)
2013-01-12 21:46 UTC, Brennan Shacklett
Details | Diff
Fix segfault and have evince fall back on normal file loading without running dbus (evince-3.6.1-no-dbus-running.patch,114.53 KB, patch)
2013-01-13 03:10 UTC, Brennan Shacklett
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brennan Shacklett 2013-01-12 21:44:52 UTC
Created attachment 335374 [details]
emerge --info

On a machine with dbus installed but not running, evince will immediately segfault when launched without a pdf and will terminate without a segfault when trying to open a pdf. If evince is built with ./configure --disable-dbus, it can then run successfully, therefore a use flag should be added so users aren't forced to run the dbus daemon in order to use evince.
Comment 1 Brennan Shacklett 2013-01-12 21:46:17 UTC
Created attachment 335376 [details, diff]
Adds a dbus use flag (default on) to the ebuild
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-01-13 00:15:51 UTC
Please see the following changelog entry for evince and the related bug report:

  27 Dec 2012; Alexandre Rostovtsev <tetromino@gentoo.org> evince-3.6.1.ebuild:
  Add missing gdbus-codegen dependency; remove dbus USE flag, which is now
  pointless since >=gtk+-3.6[X] always requires dbus (bug #448804, thanks to
  Florian Faber).

basically, evince-3.6 and its direct dependencies make it almost unavoidable to have dbus installed so we now default to have it always on.


Also please note that dbus ebuild explicitely states:

    elog "Some applications require a session bus in addition to the system"
    elog "bus. Please see \`man dbus-launch\` for more information."
    elog

Having evince segfault due to missing running dbus is not nice, but I think we would rather fix that than make it optional again.
Comment 3 Brennan Shacklett 2013-01-13 03:10:28 UTC
Created attachment 335420 [details, diff]
Fix segfault and have evince fall back on normal file loading without running dbus

Here's a patch that fixes the segfault when evince is compiled with dbus support. Unfortunately I also had to add some logic to the document open function so it falls back on the load function that doesn't use dbus, otherwise the open menu simply does nothing.
Let me know if there is something else I should do.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-01-13 10:23:33 UTC
Well it looks like a small enough patch that upstream could integrate it.
Could you please open a bug report at bugzilla.gnome.org and attach your patch there, then paste the URL here ?
Comment 5 Brennan Shacklett 2013-01-13 19:56:53 UTC
Upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=691672
Comment 6 Brennan Shacklett 2013-02-03 03:04:14 UTC
Resolved upstream.
Comment 7 Pacho Ramos gentoo-dev 2013-07-27 11:35:00 UTC
fixed in 3.8