Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 45139 - nagios-plugins-1.3.1 compile fails
Summary: nagios-plugins-1.3.1 compile fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-19 10:30 UTC by Scott Phelps
Modified: 2005-07-13 21:31 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Phelps 2004-03-19 10:30:30 UTC
When emerging nagios-plugins-1.3.1 or nagios-plugins-1.3.1-r1...

The src_compile fails with the following output:

<<<<<<<<<<<<  SNIP >>>>>>>>>>>>>
source='check_radius.c' object='check_radius.o' libtool=no \
depfile='.deps/check_radius.Po' tmpdepfile='.deps/check_radius.TPo' \
depmode=gcc3 /bin/sh ../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I. -I. -I. -I. -I. -I. -I.. -I../lib -I/usr/include/ldap -I/include -I/usr/include     -O3 -march=pentium3 -fprefetch-loop-arrays -funroll-loops -pipe -c `test -f 'check_radius.c' || echo './'`check_radius.c
check_radius.c: In function `main':
check_radius.c:167: error: too few arguments to function `rc_avpair_add'
check_radius.c:168: error: too few arguments to function `rc_avpair_add'
check_radius.c:169: error: too few arguments to function `rc_avpair_add'
check_radius.c:179: error: too few arguments to function `rc_avpair_add'
check_radius.c:185: error: too few arguments to function `rc_send_server'
make[2]: *** [check_radius.o] Error 1
make[2]: Leaving directory `/home/portage/tmp/portage/nagios-plugins-1.3.1/work/nagios-plugins-1.3.1/plugins'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/portage/tmp/portage/nagios-plugins-1.3.1/work/nagios-plugins-1.3.1/plugins'
make: *** [all-recursive] Error 1

!!! ERROR: net-analyzer/nagios-plugins-1.3.1 failed.
!!! Function src_compile, Line 49, Exitcode 2
!!! (no error message)
<<<<<<<<<<<<  SNIP >>>>>>>>>>>>>

My USE FLAGS:
USE="3dnow 3ds aavm acl acpi acpi4linux activefilter amd apache1 athena \
     autofs caps cdr cscope curl debug dga dillo dnd dv dvd ethereal faad \
     fbcon fbdev ffmpeg flac foreign-package freetds freetype fs gd \
     gphoto2 gstreamer hbci i8x0 imagemagick imap innodb ipalias java \
     javascript jbig lcd lua maildir mbox mcal md5sum mmx mng moznocompose \
     moznoirc moznomail moznoxft mozp3p mozsvg mozxmlterm mule music \
     nagios-dns nagios-ntp nagios-ping nagios-ssh neXt ofx pcmcia php pic \
     pnp ppds rplay samba sasl slp snmp sox speedo sse stencil-buffer \
     stroke tiff trusted type1 uml unicode usb videos vim-with-x wmf Xaw3d \
     xface xine xml -apm -arts -kde -gnome -postgres -qt"




Reproducible: Always
Steps to Reproduce:
1. Type emerge net-analyzer/nagios-plugins
2.
3.

Actual Results:  
See Details.
Comment 1 Michael Boman (RETIRED) gentoo-dev 2004-03-23 09:39:08 UTC
My guess is that ./configure detects radius libraries but can't get it working (perhaps non-compatible libraries are installed?)

What radius library have you installed on this system?
Comment 2 Scott Phelps 2004-03-30 12:44:46 UTC
I have this version of the library

radiusclient.h,v 1.9 2002/11/13 18:19:26
Comment 3 Michael Boman (RETIRED) gentoo-dev 2004-03-31 01:47:10 UTC
That wasn't really what I was looking for.

I need to know what package (and it's version) you got radius from. If from tarball please state download link.

Unfortunatly nagios-plugins does not work will all radius libraries.
Comment 4 Scott Phelps 2004-03-31 06:11:02 UTC
I really don't know!  Can you offer any hints as to what package may have installed the radius library?

BTW, I would just assume disable it.  I tried renaming it, LOL, but that didn't work.  

BTW, I saw the followinw constant in the config.h file:
<<<snip>>>
/* Define to 1 if you have the `radiusclient' library (-lradiusclient). */
#define HAVE_LIBRADIUSCLIENT 1
<<snip>>

Is there any way I can have this set to "0" in the ebuild?  I would just prefer to disable this feature.

Thanks!
Comment 5 Richard Scott 2004-05-20 03:26:30 UTC
I have some additional info regarding the radius client that is causing this problem. 

It seems that PPP installs support for radius even if you don't want or need it :-( 

The ebuild in net-dialup/ppp for version 2.4.2-r2 automatically compiles support for it and doesn't seem to give you any option of disabling this at emerge time :-(

If you unmerge ppp and emerge nagios-plugins all will be ok. you will then need to emerge ppp if you really need it.
Comment 6 Cory Visi (RETIRED) gentoo-dev 2004-07-19 13:31:21 UTC
This is not really a bug with nagios-plugins. Maybe a local use flag for "radius" would be nice, but otherwise there is nothing else wrong.

This is bad bad behavior on the part of the net-dialup/ppp ebuild. Heinrich introduced a "make install" in the radius client library for ppp in ppp-2.4.2_beta3-r1. This is not right! The radius client library is only packaged with ppp so that it can LINK STATICALLY.

I'm not sure, but this might have been a fix to address Bug 38550. However, installing the radius plugin and the radius client library are two different things.

The radius client library is a separate package that should have its own ebuild if we really want it installed. Indeed there are already 2 other radius libraries with ebuilds available. ppp itself should not be installing a radius client.

The lines:
        cd radiusclient
        make DESTDIR=${D} install || die
in ppp-2.4.2-r2.ebuild need to be removed (in my opinion).

I added Heinrich to the CC. I will gladly take care of these two suggestions if the maintainers would like me to.

Scott and Richard, thank you for doing the research on this!
Comment 7 Michael Glauche (RETIRED) gentoo-dev 2004-08-06 05:28:15 UTC
removing the header files makes nagios-plungins compile again ...
Comment 8 Eldad Zack (RETIRED) gentoo-dev 2004-08-20 08:09:48 UTC
I've removed the radius portion in the configure script in 1.3.1-r1.

This is due to the fact that freeradius does not build with nagios-plugins, ppp breaks it, and cistronradius doesn't supply libraries at all.


Cory, please file a bug against ppp if you see it to be appropriate.
Comment 9 CJ Kucera 2005-07-13 21:31:55 UTC
IMO there should really be a USE flag for applying that 'noradius' patch.  I
just spent quite a bit of time trying to figure out why Nagios wasn't building
check_radius only to find out that there's a patch applied to nagios-plugins
which explicitly disabled the support.

I agree that there's probably some issue with the ppp package (which I didn't
have installed, and I *did* have the radiusclient package installed), but it'd
be nice to be able to have the USE flag there.  Perhaps throw some einfo lines
up to let the user know about the ppp problems.

Also, it'd be nice to add check_radius into the Summary of this bug.  As it
stands it's not very informative for people searching around.