Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 45133 - Please test media-libs/portaudio
Summary: Please test media-libs/portaudio
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 All
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-19 09:31 UTC by Jeremy Huddleston (RETIRED)
Modified: 2004-03-30 15:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make portaudio honor the CFLAGS variable (portaudio-honor-cflags.patch,222 bytes, patch)
2004-03-26 15:02 UTC, Travis Tilley (RETIRED)
Details | Diff
patch to make portaudio honor CFLAGS (portaudio-honor-cflags.patch,441 bytes, patch)
2004-03-26 15:13 UTC, Travis Tilley (RETIRED)
Details | Diff
patches the portaudio ebuild to check for amd64 and add -fPIC to CFLAGS (portaudio-18-r1.patch,467 bytes, patch)
2004-03-26 15:40 UTC, Travis Tilley (RETIRED)
Details | Diff
patch to make portaudio compile with -fPIC (portaudio-use-fpic.patch,323 bytes, patch)
2004-03-27 05:12 UTC, Travis Tilley (RETIRED)
Details | Diff
patch to portaudio ebuild to apply fpic patch (portaudio-fpic-ebuild.patch,367 bytes, patch)
2004-03-27 05:21 UTC, Travis Tilley (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston (RETIRED) gentoo-dev 2004-03-19 09:31:20 UTC
timidity++ supports this API, so I'd like to get it into all archs that timidity++ supports.
Comment 1 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:00:32 UTC
The best way to make sure an ebuild gets tested and fixed is to test it yourself and then post the results.

I got portaudio to compile by patching the makefile to honor cflags and then adding CFLAGS="-fPIC" after make -f Makefile.linux
Comment 2 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:02:09 UTC
Created attachment 28110 [details, diff]
patch to make portaudio honor the CFLAGS variable

this patch makes the portaudio Makefile honor the CFLAGS variable.
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2004-03-26 15:07:50 UTC
Travis, I'm not quite sure what you mean here?  This is a request for a keyword to be added to a current ebuild.  Were you haveing problems with the ebuild before?  If so, please open a separate bug report.

Thanks.
Comment 4 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:13:07 UTC
Created attachment 28112 [details, diff]
patch to make portaudio honor CFLAGS

This patch makes portaudio honor CFLAGS... and is actually in a usable format,
unlike the last patch.
Comment 5 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:14:54 UTC
portaudio wont compile on amd64, why would you want to add a keyword without making it able to compile first?
Comment 6 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:37:04 UTC
To clarify, without any modification, portaudio fails with the following error:

/usr/lib/gcc-lib/x86_64-pc-linux-gnu/3.3.3/../../../../x86_64-pc-linux-gnu/bin/ld: ./pa_common/pa_lib.o: relocation R_X86_64_32S can not be used when making a shared object; recompile with -fPIC
./pa_common/pa_lib.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make: *** [sharedlib] Error 1

This is easily fixed just by adding -fPIC on amd64, but the makefile doesn't honor CFLAGS, so I first patched it to honor CFLAGS and edited the ebuild to add -fPIC to CFLAGS on amd64.

hppa and alpha would also need -fPIC, I think... and a few other archs.
Comment 7 Travis Tilley (RETIRED) gentoo-dev 2004-03-26 15:40:50 UTC
Created attachment 28115 [details, diff]
patches the portaudio ebuild to check for amd64 and add -fPIC to CFLAGS

this patches the portaudio ebuild to append-flags -fPIC if running on an amd64
box, fixing PIC related compile errors. I'd like to note that it makes use of
the system CFLAGS setting as well, so it might need a filter-flags?
Comment 8 Jon Portnoy (RETIRED) gentoo-dev 2004-03-26 17:13:24 UTC
Rather than using append-flags, it'd be better to patch the Makefile to append -fPIC for any libraries. On x86 it provides performance benefits, and on other archs it makes it actually work. http://dev.gentoo.org/~ciaranm/tmp/347.txt has information about it.
Comment 9 Jeremy Huddleston (RETIRED) gentoo-dev 2004-03-26 18:25:11 UTC
Regarding comment #5, that's the point of this bug ;).  I don't have amd64 hardware, so I have to put in a bug request to get them to test out ebuilds on that arch.  I didn't realize that your problem was amd64 specific.  Thanks for helping out with this effort.
Comment 10 Travis Tilley (RETIRED) gentoo-dev 2004-03-27 05:08:16 UTC
well, portaudio is a library... but if it's ok to have -fPIC on all archs, then patching the makefile to honor cflags is a bit overkill. I'll up another patch that just adds -fPIC.
Comment 11 Travis Tilley (RETIRED) gentoo-dev 2004-03-27 05:12:42 UTC
Created attachment 28143 [details, diff]
patch to make portaudio compile with -fPIC
Comment 12 Travis Tilley (RETIRED) gentoo-dev 2004-03-27 05:15:01 UTC
eradicator - Well dont I feel silly, I had assumed that you did have an amd64 box. ^_^;
Comment 13 Travis Tilley (RETIRED) gentoo-dev 2004-03-27 05:21:35 UTC
Created attachment 28144 [details, diff]
patch to portaudio ebuild to apply fpic patch
Comment 14 Travis Tilley (RETIRED) gentoo-dev 2004-03-29 08:50:44 UTC
I'm not done with my new developer mentoring period, so I need someone to either commit this to cvs and close this bug or let me know what further changes need to be made to do so.
Comment 15 Travis Tilley (RETIRED) gentoo-dev 2004-03-30 15:49:22 UTC
fix in cvs, wee