Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 450774 - python-r1.eclass - support for user patches via epatch_user
Summary: python-r1.eclass - support for user patches via epatch_user
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: Inclusion, NeedPatch
Depends on:
Blocks:
 
Reported: 2013-01-07 23:03 UTC by Sergey Popov (RETIRED)
Modified: 2013-01-08 06:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Popov (RETIRED) gentoo-dev 2013-01-07 23:03:42 UTC
It would be nice to have such support in python-r1/distutils-r1 based ebuilds
Comment 1 Mike Gilbert gentoo-dev 2013-01-07 23:11:43 UTC
python-r1 does not export phase functions.
distutils-r1 already calls epatch_user in distutils-r1_python_prepare_all.

What more do you want? :)
Comment 2 Sergey Popov (RETIRED) gentoo-dev 2013-01-07 23:41:32 UTC
(In reply to comment #1)
> distutils-r1 already calls epatch_user in distutils-r1_python_prepare_all.

i have missed that...

>python-r1 does not export phase functions.

Can this be modified or there is some kind of policy or technical/organizational limitation for this eclass to not export any functions at all?
Comment 3 Mike Gilbert gentoo-dev 2013-01-08 00:03:37 UTC
python-r1 is generally used in ebuilds which define phase functions already. I don't think exporting src_prepare just to call epatch_user would be very useful since it is likely to be overridden anyway.

From a policy standpoint, I don't think an eclass that is primarily composed of helper functions should export random phase functions.

If you really don't want to define src_prepare yourself, it would be better to utilize base.eclass.
Comment 4 Sergey Popov (RETIRED) gentoo-dev 2013-01-08 01:24:53 UTC
(In reply to comment #3)
> python-r1 is generally used in ebuilds which define phase functions already.
> I don't think exporting src_prepare just to call epatch_user would be very
> useful since it is likely to be overridden anyway.

Ok, reasonable
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-08 06:25:11 UTC
Well, python-r1 is mostly designed to work with build system eclasses like autotools-utils or cmake-utils. Those usually utilize epatch_user on their own.