Bug 450328 – app-forensics/openscap-0.9.3 - xccdf_policy.c: 392:14: error: expected identifier or '(' before numeric constant; 411:2: error: lvalue required as unary '&' operand

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anton Bolshakov 2013-01-05 02:41:08 UTC]

make[3]: Leaving directory `/var/tmp/portage/app-forensics/openscap-0.9.3/work/openscap-0.9.3/src/XCCDF'
Making all in XCCDF_POLICY
make[3]: Entering directory `/var/tmp/portage/app-forensics/openscap-0.9.3/work/openscap-0.9.3/src/XCCDF_POLICY'
  CC       libxccdf_policy_la-xccdf_policy.lo
xccdf_policy.c: In function 'xccdf_policy_resolve_item':
xccdf_policy.c:392:14: error: expected identifier or '(' before numeric constant
xccdf_policy.c:393:14: error: expected identifier or '(' before numeric constant
xccdf_policy.c:411:2: error: lvalue required as unary '&' operand
xccdf_policy.c:411:2: error: lvalue required as unary '&' operand
make[3]: *** [libxccdf_policy_la-xccdf_policy.lo] Error 1

emerge --info
Portage 2.1.11.31 (hardened/linux/amd64, gcc-4.5.4, glibc-2.15-r3, 3.5.4-pentoo x86_64)
=================================================================
System uname: Linux-3.5.4-pentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_M_520_@_2.40GHz-with-gentoo-2.1
Timestamp of tree: Sat, 05 Jan 2013 02:00:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8::pentoo
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4, 4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r4
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo local-overlay pentoo
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA PUEL AdobeFlash-10.3 google-talkplugin dlj-1.1 google-chrome Oracle-BCLA-JavaSE Intel-SDP"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -mtune=generic -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /var/lib/hsqldb"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -mtune=generic -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.channelx.biz/"
INSTALL_MASK="*.la"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /pentoosvn"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl alsa amd64 avahi bash-completion berkdb branding bzip2 cli consolekit cracklib crypt cxx dbus dri exif flac fortran fuse gdbm gnome gnome-keyring gphoto2 gstreamer gtk hardened iconv ipv6 java jpeg justify lcms libnotify mmx modules mp3 mudflap multilib ncurses netlink networkmanager nls nptl opengl openmp oss pam pax_kernel pcre png policykit pppd qt3support qt4 readline samba sdl session spell sse sse2 ssl syslog tcpd udev unicode urandom vaapi wxwidgets x264 xcb xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2 canon samsung" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev vesa intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Anton Bolshakov 2013-01-05 02:41:49 UTC]

Created attachment 334474 [details]
build.log

[Comment 2 Anton Bolshakov 2013-01-07 14:37:28 UTC]

Created attachment 334732 [details, diff]
xccdf_policy.patch

We narrowed down the problem with Montjoie.
The attached patch helped to fix the problem

[Comment 3 Markos Chandras (RETIRED) 2013-01-07 15:31:50 UTC]

(In reply to comment #2)
> Created attachment 334732 [details, diff] [details, diff]
> xccdf_policy.patch
> 
> We narrowed down the problem with Montjoie.
> The attached patch helped to fix the problem

Is this patch upstream?

[Comment 4 Anton Bolshakov 2013-01-08 01:07:44 UTC]

(In reply to comment #3)
> 
> Is this patch upstream?

No, that patch is mine, feel free to submit it to the upstream.

I changed local variable names in the xccdf_policy_resolve_item function so should be safe to do so.

[Comment 5 LABBE Corentin 2013-01-08 07:50:47 UTC]

Upstream is now aware of the problem and they will solve it in the next upstream release certainly.
Since I cannot reproduce this bug, the better way for solving it is to add epatchuser at the end of src_prepare for letting people having this problem to solve it with the patch submitted.

Anyway, in my next openscap ebuild, I will add epatchuser in this way.

[Comment 6 Simon Lukasik 2013-01-08 10:45:38 UTC]

This shall be fixed upstream in

http://git.fedorahosted.org/cgit/openscap.git/commit/?id=736c6d0da308acbeee7692d574024f35fb652685

Thank You!

[Comment 7 Willard Dawson 2013-01-08 13:01:31 UTC]

(In reply to comment #5)
> Upstream is now aware of the problem and they will solve it in the next
> upstream release certainly.
> Since I cannot reproduce this bug, the better way for solving it is to add
> epatchuser at the end of src_prepare for letting people having this problem
> to solve it with the patch submitted.
> 
> Anyway, in my next openscap ebuild, I will add epatchuser in this way.

I also experienced this bug, and am happy to say the patch worked for me.  Inasmuch as I had to patch my local ebuild just as you say, I'll attach a diff/patch for the ebuild in case anyone else runs into this bug to save them the effort, simplistic though it may be.

[Comment 8 Willard Dawson 2013-01-08 13:02:53 UTC]

Created attachment 334786 [details]
patch ebuild to add epatch statement to apply policy.patch

[Comment 9 Anton Bolshakov 2013-01-08 22:41:04 UTC]

(In reply to comment #5)
> Since I cannot reproduce this bug, the better way for solving it is to add
> epatchuser at the end of src_prepare for letting people having this problem to > solve it with the patch submitted.


I don't understand that approach. Why don't push -r1 with the patch and close the bug?..

I have no idea what so special about my setup but as long as there are at least 2 users with the same problem do expect a lot more more.

[Comment 10 milton 2013-01-29 21:55:46 UTC]

Same error here, could someone please bump a -r1 ebuild with the patch in the tree? The current ebuild in tree does not compile... :(
Thanks!

[Comment 11 Markos Chandras (RETIRED) 2013-01-30 18:43:34 UTC]

+*openscap-0.9.3-r1 (30 Jan 2013)
+
+  30 Jan 2013; Markos Chandras <[e-mail]>
+  +files/openscap-0.9.3-policy.patch, +openscap-0.9.3-r1.ebuild, metadata.xml:
+  Revbump with patch to fix bug #450328. Thanks to Anton Bolshakov
+  <[e-mail]>
+