Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 449982 - sys-block/iscsitarget-1.4.20.2_p20130103 fails to build on Linux 3.7
Summary: sys-block/iscsitarget-1.4.20.2_p20130103 fails to build on Linux 3.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal
Assignee: Richard Yao (RETIRED)
URL:
Whiteboard:
Keywords: Bug, Goal
: 462624 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-03 11:33 UTC by Richard Yao (RETIRED)
Modified: 2013-08-21 14:49 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sys-block/iscsitarget-1.4.20.2_p20130103 build failure (modified ebuild to disable kernel version check) (build.log,11.65 KB, text/plain)
2013-01-03 11:33 UTC, Richard Yao (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2013-01-03 11:33:37 UTC
Created attachment 334174 [details]
sys-block/iscsitarget-1.4.20.2_p20130103 build failure (modified ebuild to disable kernel version check)

Currently, upstream SVN lacks support for Linux 3.7, which results in a build failure. This needs to be addressed, so I am opening this bug before one of our users does.

There are multiple problems with the iSCSITarget build system.

1. The build system applies patches based on kernel version
2. The kver_le macro used to decide which patches are valid does not return true on equal.
3. The upper bounds on the kernel versions are not enforced when applying these patches.
4. There are regressions in support for Linux 2.6.32 and earlier.

As of sys-block/iscsitarget-1.4.20.2_p20130103, we address #2, #3 and #4 (only tested as far back as Linux 2.6.32). However, those are hacks around the real problem, which is #1.

Applying patches based on kernel version will lead to build failures with custom kernels, which is something that should change. I would love to adopt autotools like sys-kernel/spl did to address this, but I need to talk to upstream first before we decide what will be done.
Comment 1 Doug Goldstein (RETIRED) gentoo-dev 2013-01-04 03:53:01 UTC
tbh, I'd drop iscsitarget from base-system and let ryao have at it. Its deprecated and won't be getting mainlined. The kernel now has LIO from 3.1 and on , which will be the preferred way.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-03-22 17:02:10 UTC
*** Bug 462624 has been marked as a duplicate of this bug. ***
Comment 3 Richard Yao (RETIRED) gentoo-dev 2013-08-21 14:49:24 UTC
sys-block/iscsitarget-1.4.20.2_p20130821 is now in tree. It adds support for Linux 3.7 through 3.11.