Bug 449230 – Stabilize app-text/xchm-1.21

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2012-12-29 19:14:28 UTC]

Works ok for me since added to the tree

Thanks

Reproducible: Always

[Comment 1 Ryan Hill (RETIRED) 2012-12-30 19:56:41 UTC]

Please stabilize app-text/chm-1.21.

[Comment 2 Vicente Olivert Riera (RETIRED) 2013-01-07 12:06:19 UTC]

x86: ok

[Comment 3 Vicente Olivert Riera (RETIRED) 2013-01-07 12:20:33 UTC]

amd64: ok

[Comment 4 Chema Alonso Josa (RETIRED) 2013-01-07 12:43:56 UTC]

Some thoughts:

1. CXXFLAGS are not respected, -fnostrict-aliasing -W -Wall are added after $CXXFLAGS at line 5512 in the configure script.

I'd reorder it this way:

CXXFLAGS="$WX_CXXFLAGS_ONLY -W -Wall $CXXFLAGS"

for the user to gain control over CXXFLAGS.

2. I'd add || die to the ebuild at lines 35, 36 and 37

Marked stable for amd64

[Comment 5 Vicente Olivert Riera (RETIRED) 2013-01-07 20:28:10 UTC]

ppc: ok

[Comment 6 Chema Alonso Josa (RETIRED) 2013-01-08 15:22:07 UTC]

(In reply to comment #4)
> Some thoughts:
> 
> 1. CXXFLAGS are not respected, -fnostrict-aliasing -W -Wall are added after
> $CXXFLAGS at line 5512 in the configure script.

Please ignore this comment, CXXFLAGS are ok

[Comment 7 Anthony Basile 2013-01-11 19:03:36 UTC]

stable ppc, thanks vincent

[Comment 8 Agostino Sarubbo 2013-01-13 11:32:14 UTC]

x86 stable. Last arch, closing