Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 449210 - sys-kernel/gentoo-sources/3.7 and higher missing fbcondecor patch
Summary: sys-kernel/gentoo-sources/3.7 and higher missing fbcondecor patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-29 16:26 UTC by Billy DeVincentis
Modified: 2013-01-18 13:49 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
working patch for kernels 3.7 and higher (4200_fbcondecor-0.9.6.patch,68.07 KB, text/plain)
2013-01-16 16:49 UTC, jeremy
Details
diff (4200_fbcondecor-0.9.6.patch.diff,863 bytes, text/plain)
2013-01-16 17:03 UTC, jeremy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Billy DeVincentis 2012-12-29 16:26:21 UTC
As of gentoo-sources 3.7, fbcondecor patch apparently was incompatible and was removed but has never been updated. This renders splashutils and the whole gensplash boot splash useless. I'm hoping someone can modify the patch to make it work again.
Comment 1 jeremy 2013-01-16 16:49:45 UTC
Created attachment 335836 [details]
working patch for kernels 3.7 and higher
Comment 2 jeremy 2013-01-16 16:56:47 UTC
Ive attached a modified patch. This will only work on kernels 3.7 or higher.

What happened was they slightly changed the include/linux/fb.h file.

On kernels 3.7 and above the code that used to reside solely in include/linux/fb.h has split up and some of it was moved to include/uapi/linux/fb.h

Which was why the previous patch was failing. 

both include/linux/fb.h and include/uapi/linux/fb.h need patched. Which this patch does. I just changed a few lines in the patch to route the correct blocks of code to these files.
Comment 3 jeremy 2013-01-16 17:03:15 UTC
Created attachment 335842 [details]
diff
Comment 4 Billy DeVincentis 2013-01-16 23:53:12 UTC
Seems like Michal Januszewski has discontinued the project as far as he is concerned (as per his website). Hopefully someone can step up and take over maintenance.
Comment 5 jeremy 2013-01-17 00:39:29 UTC
(In reply to comment #4)
> Seems like Michal Januszewski has discontinued the project as far as he is
> concerned (as per his website). Hopefully someone can step up and take over
> maintenance.

I seen that. Also his dev page is a dead link. It would be great if somebody with the skills and knowledge would step up. Ill help when and where I can. But my lack of knowledge and skills as far as coding in general goes in addition to not knowing code for this particular project consisting of the kernel patch as well as the userspace program (splashutils) is going to put a barrier. 

This was a rather simple fix once I looked at the files it wanted to patch and the code contained therein. 

Once I noticed the large amount of code that was missing from include/linux/fb.h I pulled the fb.h from the 3.6 tree to compare so I knew exactly how much code was missing and exactly what it was. Then searched through the 3.7 tree looking to see if it was moved. I was about to just add the missing code back in and hope for the best until i accidently stumbled upon it.

Moral of the story is I'm no coder or dev. Far from it actually. I know bash and Php and know how to read patch files but beyond that I'm I wouldn't know where to begin. 

This fix was basically born out of a mixture of bordom and sheer luck.
Comment 6 Billy DeVincentis 2013-01-18 00:18:07 UTC
Well devs, can someone step up and include this patch in the portage tree. I can't believe that gensplash is going to die because spock has retired it.
Comment 7 Mike Pagano gentoo-dev 2013-01-18 13:49:46 UTC
Released in gentoo-sources-3.7.3