Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 448750 - dev-php/PEAR-Mail: Fix non-static function warning
Summary: dev-php/PEAR-Mail: Fix non-static function warning
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL: http://pear.php.net/bugs/bug.php?id=1...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-12-27 01:14 UTC by Michael Orlitzky
Modified: 2014-10-30 04:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Declare the factory function static (PEAR-Mail-static-factory-fix.patch,445 bytes, patch)
2012-12-27 01:14 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2012-12-27 01:14:10 UTC
Created attachment 333416 [details, diff]
Declare the factory function static

The Mail::factory method is used statically, but not declared static. PHP5 has started to complain about this. The easy fix is to declare the method static, since that was what was intended in the first place.

This hasn't been fixed upstream for one of two reasons,

1) It breaks php-4 compatibility.
2) More likely, upstream is just dead.

We don't have to worry about (1), of course. Adding epatch_user() support to the PEAR eclass would also allow me to fix this without an -r1.
Comment 1 Michael Orlitzky gentoo-dev 2014-10-30 04:42:37 UTC
It looks like PEAR-Mail was forked into PEAR-Mail2, so this isn't gonna happen in the old branch.