Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 44684 - Test if ECVS_SERVER is already set is missing in these cvs.eclass ebuilds
Summary: Test if ECVS_SERVER is already set is missing in these cvs.eclass ebuilds
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Tal Peer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-14 11:18 UTC by Torsten Veller (RETIRED)
Modified: 2005-04-26 14:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Veller (RETIRED) gentoo-dev 2004-03-14 11:18:03 UTC
Please, test if ECVS_SERVER is already set:
[ -z "$ECVS_SERVER" ] && ECVS_SERVER="[]


# egrep -r --include="*.ebuild" "ECVS_SERVER" .


malverian:
./dev-games/cel-cvs/cel-cvs-0.97.ebuild:ECVS_SERVER="cvs.cel.sourceforge.net:/cvsroot/cel"
./dev-games/crystalspace-cvs/crystalspace-cvs-0.97.ebuild:ECVS_SERVER="cvs.sourceforge.net:/cvsroot/crystal"

mr_bones_:
./games-emulation/dosbox-cvs/dosbox-cvs-20030809.ebuild:ECVS_SERVER="cvs.sourceforge.net:/cvsroot/dosbox" 

vapier:
./games-fps/duke3d/duke3d-20030817-r1.ebuild:ECVS_SERVER="icculus.org:/cvs/cvsroot"

emacs:
./app-editors/emacs-cvs/emacs-cvs-21.3.50.ebuild:ECVS_SERVER="savannah.gnu.org:/cvsroot/emacs"

ruby:
./dev-lang/ruby-cvs/ruby-cvs-1.8.1-r1.ebuild:ECVS_SERVER="cvs.ruby-lang.org:/src"
./dev-lang/ruby-cvs/ruby-cvs-1.8.1.ebuild:ECVS_SERVER="cvs.ruby-lang.org:/src"
./dev-lang/ruby-cvs/ruby-cvs-1.9.0.ebuild:ECVS_SERVER="cvs.ruby-lang.org:/src"
./dev-lang/ruby-cvs/ruby-cvs-1.9.0-r1.ebuild:ECVS_SERVER="cvs.ruby-lang.org:/src"

base-system:
./sys-libs/ldetect/ldetect-0.4.7.ebuild:ECVS_SERVER="cvs.mandrakesoft.com:/cooker"
./sys-libs/ldetect-lst/ldetect-lst-0.1.4.ebuild:ECVS_SERVER="cvs.mandrakesoft.com:/cooker"

python:
./dev-python/twisted-cvs/twisted-cvs-20031103.ebuild:ECVS_SERVER="cvs.twistedmatrix.com:/cvs"

common-lisp:
./dev-lisp/ecls-cvs/ecls-cvs-1.ebuild:ECVS_SERVER="cvs.sourceforge.net:/cvsroot/ecls"

usata:
./app-emacs/wanderlust-cvs/wanderlust-cvs-2.11.ebuild:ECVS_SERVER="cvs.m17n.org:/cvs/root"

emacs:
./app-emacs/slime-cvs/slime-cvs-0.ebuild:ECVS_SERVER="common-lisp.net:/project/slime/cvsroot"
./app-emacs/slime-cvs/slime-cvs-0-r1.ebuild:ECVS_SERVER="common-lisp.net:/project/slime/cvsroot"
./app-emacs/erc-cvs/erc-cvs-4.1.ebuild:ECVS_SERVER="cvs.erc.sourceforge.net:/cvsroot/erc"
./app-emacs/gnus-cvs/gnus-cvs-5.11.ebuild:ECVS_SERVER="cvs.gnus.org:/usr/local/cvsroot"
./app-emacs/ilisp-cvs/ilisp-cvs-5.12.0.ebuild:ECVS_SERVER="cvs-pserver.sourceforge.net:80/cvsroot/ilisp"

net-irc:
./net-irc/irssi-cvs/irssi-cvs-0.2.ebuild:ECVS_SERVER="cvs.irssi.org:/home/cvs"

pYrania:
./net-misc/netcomics-cvs/netcomics-cvs-0.14.1.ebuild:ECVS_SERVER="cvs.sourceforge.net:/cvsroot/netcomics"

tantive:
./sys-cluster/gomd-cvs/gomd-cvs-0.2_beta1.ebuild:ECVS_SERVER="savannah.nongnu.org:/cvsroot/gomd"

net-p2p:
./net-p2p/giftui-cvs/giftui-cvs-0.0.1.ebuild:ECVS_SERVER="cvs.tuxfamily.org:/cvsroot/giftui"

vapier:
./x11-wm/enlightenment/enlightenment-0.16.9999.ebuild:ECVS_SERVER="cvs.sourceforge.net:/cvsroot/enlightenment"

coredumb:
./dev-php/php-cvs/php-cvs-5.0.ebuild:ECVS_SERVER="cvs.php.net:/repository"
./dev-php/php-cvs/php-cvs-5.0-r1.ebuild:ECVS_SERVER="cvs.php.net:/repository"
./dev-php/php-cvs/php-cvs-5.0-r2.ebuild:ECVS_SERVER="cvs.php.net:/repository"

?:
./fresco-base/fresco-cvs/fresco-cvs-20021020.ebuild:ECVS_SERVER="cvs.fresco.org:/cvs/fresco"
./fresco-base/fresco-cvs/fresco-cvs-20030127.ebuild:ECVS_SERVER="cvs.fresco.org:/cvs/fresco"
./fresco-base/fresco-cvs/fresco-cvs-20030220.ebuild:ECVS_SERVER="cvs.fresco.org:/cvs/fresco"

Reproducible: Always
Steps to Reproduce:
Comment 1 SpanKY gentoo-dev 2004-03-16 09:19:34 UTC
i really dont know what you're asking for or wtf you're trying to show, but i'm pretty sure this is invalid

root@vapier 0 DirectFB-0.9.20 # grep ECVS_SERVER /usr/portage/eclass/cvs.eclass | head -n 1
[ -z "$ECVS_SERVER" ] && ECVS_SERVER="offline"
Comment 2 Torsten Veller (RETIRED) gentoo-dev 2004-03-16 10:24:02 UTC
i am asking for this change, because this change makes it possible to emerge an ebuild (which uses the cvs.eclass) without connecting the specified cvs server.

And i think gentoo wants to give the user the choice to do this. So my wish seems valid to me. I reopened this bug.

My Wish: If *i* set ECVS_SERVER to offline (or whatever), the ebuild wants to respect it!

Your quoted part of the eclass doesn't help, because it fails in all cases where ECVS_SERVER is set in the ebuild (example: games-fps/duke3d/duke3d-20030817-r1.ebuild:ECVS_SERVER="icculus.org:/cvs/cvsroot")
ECVS_SERVER is set, so it will never be "offline"! This check in cvs.eclass is useful if your source is (for example) from a tarball, so you don't need to define EVS_SERVER in the ebuild.
Comment 3 SpanKY gentoo-dev 2004-03-16 18:05:36 UTC
what you want to do is not an option

coredumb: perhaps add another variable, say 'ECVS_OFFLINE' ?  that way the user can `export ECVS_OFFLINE=1` and then in src_unpack() abuse it ?
Comment 4 Torsten Veller (RETIRED) gentoo-dev 2004-03-26 03:34:14 UTC
i added to my ecvs.eclass:


# ECVS_SERVER -- CVS path  (<--- NAME or SERVER?)
[....]
[ -z "$ECVS_SERVER" ] && ECVS_SERVER="offline"
+
+ # userdefined: set ECVS_OFFLINE=1 to run in offline mode
+ #(i.e sources must be available in ECVS_TOP_DIR).
+ [ -n "$ECVS_OFFLINE" ] && [ "$ECVS_OFFLINE" != "0" ] && ECVS_SERVER="offline"


Comments? Can this test be written easier? Is it necessary to test if ECVS_OFFLINE not null?
Comment 5 Torsten Veller (RETIRED) gentoo-dev 2004-07-03 16:19:36 UTC
Is there any chance to see this (IMO) helpful variable? Or any other way (beneath editing the ebuild) to emerge a cvs package while being offline?
Comment 6 Torsten Veller (RETIRED) gentoo-dev 2005-04-26 14:41:50 UTC
ECVS_CVS_COMMAND="true" emerge ... works around the prob in most cases