44664 – sys-apps/hotplug-20040311 : pci.rc syntax error (shell limitation ?)

Bug 44664 - sys-apps/hotplug-20040311 : pci.rc syntax error (shell limitation ?)

Summary: sys-apps/hotplug-20040311 : pci.rc syntax error (shell limitation ?)

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-03-14 05:30 UTC by Stephane Loeuillet
Modified:	2004-03-20 11:24 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephane Loeuillet 2004-03-14 05:30:07 UTC

on boot, i have a syntax error on pci.rc on lines 50 & 51 :

	if [ "$LISTER" = "" -o ! -f /proc/bus/pci/devices
		 -o ! -x pci.agent ]; then

because it tells the [ on line 50 is not closed by a ] (which is in the following line)

ll /bin/sh
lrwxrwxrwx  1 root root 4 d

Comment 1 Stephane Loeuillet 2004-03-14 05:30:07 UTC

on boot, i have a syntax error on pci.rc on lines 50 & 51 :

	if [ "$LISTER" = "" -o ! -f /proc/bus/pci/devices
		 -o ! -x pci.agent ]; then

because it tells the [ on line 50 is not closed by a ] (which is in the following line)

ll /bin/sh
lrwxrwxrwx  1 root root 4 déc 28 04:32 /bin/sh -> bash

got bash 2.05b-r9
kernel 2.4.25

i suppose that not wrapping would fix it.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.3, glibc-2.3.3_pre20040207-r0, 2.4.25)
=================================================================
System uname: 2.4.25 i686 AMD Athlon(tm) XP 2600+
Gentoo Base System version 1.4.3.13p1
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs buildpkg ccache digest sandbox strict userpriv"
GENTOO_MIRRORS="ftp://gentoo.mirrors.pair.com/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/usr/portage/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow X aalib accessibility acpi alsa apache2 avi berkdb bonobo cdr crypt
cups doc dv dvd dvdr encode esd ethereal evo faad flac flash foomaticdb gd gdbm
gif gnome gnomedb gphoto2 gstreamer gtk gtk2 gtkhtml innodb ipv6 joystick jpeg
ldap libg++ libgda libwww mad mikmod mmx mozilla mpeg mysql ncurses nls
oggvorbis opengl oss pam pda pdflib perl pic plotutils png postgres ppds python
quicktime readline samba sasl sdl slang snmp spell sse ssl svga tcpd tetex
threads tiff truetype usb videos x86 xml xml2 xv zlib"

Comment 2 Stephane Loeuillet 2004-03-14 05:35:16 UTC

fixed in CVS it seems :
http://cvs.sourceforge.net/viewcvs.py/linux-hotplug/admin/etc/hotplug/pci.rc?sortby=date

Comment 3 Greg Kroah-Hartman (RETIRED) gentoo-dev

2004-03-20 11:24:57 UTC

Fixed in upstream, will show up in next release.